[pve-devel] [PATCH manager 00/10] Display the SCSI controller type when adding a new drive

[Emmanuel Kasper]

Since we switched to the SCSI controller in the Wizard as the recommended controller
for hard disks (using VirtIO scsi in the backend) it was not clear for users
that they were using a VirtIO driver for the disk.
An example of this would be:
https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056
This came in the trainings as well.

Example before / after:
Before: http://imgur.com/a/Ozy6v
After: http://imgur.com/a/axJBa

This unfortunately does not play well with the controller selection based on the Iothread
checkbox, as the Bus picker list would then needed to be updated based on a checkbox selection.
IMHO, it is more important to provide a good visual feedback on which elements the user is 
manipulating, so I reverted this change, which was used only in the wizard anyway.

About the patch serie:
 * 01-06 is some refactoring work to prepare for the new combo box
 * 07 use the new combobox when adding a disk
 * 08-10 use the new combobox when adding a disk in the wizard

Emmanuel Kasper (10):
  Do not change the SCSI controller type when iothread was selected
  Move Wizard static properties to class body
  Do not use 'autoselect' as a boolean when preselecting a bus
  Remove unused noScsi parameter
  Save the components we found via down() in a variable for later reuse.
  Use the noVirtiIO ControllerSelector property to build the list of
    controllers
  Enhance BusStypeSelector with the SCSI controller description
  Improve the display names of VirtIO-blk and VirtIO SCSI controllers
  Make room in QemuWizard and Edit Window so that the larger combo boxes
    properly fit.
  Propagate the SCSI hw to the Hard Disk panel when selecting an OS

 www/manager6/Utils.js                   |  4 +-
 www/manager6/form/BusTypeSelector.js    | 56 ++++++++++++++++++++++------
 www/manager6/form/ControllerSelector.js | 66 ++++++++++++++++-----------------
 www/manager6/qemu/CDEdit.js             |  3 ++
 www/manager6/qemu/CreateWizard.js       |  3 +-
 www/manager6/qemu/HDEdit.js             | 12 +++---
 www/manager6/qemu/OSTypeEdit.js         | 11 ++++--
 www/manager6/window/Edit.js             |  3 ++
 www/manager6/window/Wizard.js           | 16 ++++----
 9 files changed, 107 insertions(+), 67 deletions(-)

-- 
2.11.0