[pve-devel] [PATCH manager/storage v3 00/20] pveceph storage.cfg maangement

[Thomas Lamprecht]

On 08/31/2017 11:38 AM, Fabian Grünbichler wrote:
> this patch series implements storage.cfg management for pveceph-managed ceph
> clusters.
> 
> the following is implemented:
> 
> - add new 'pveceph' flag to RBD storages, using /etc/pve/ceph.conf instead of
>    a hard-coded monitor list
> - optionally adding/removing storages when creating/destroying a pool + GUI
> - creating/destroying pools happens in a worker now
> - adding/removing a pveceph-managed RBD storage handles its keyring as well
> 
> the following is still missing:
> - make switching to (and from?) pveceph possible via API for an existing storage
> - adapt RBD add/edit dialogue in GUI (follow up by Thomas?
I can give it a look.

> 
> high-level changes since v2 based on Thomas' feedback:
> - moved keyring handling to pve-storage (PVE::API2::Storage::Config)
> - dropped add/list/removestorages API paths in PVE::API2::Ceph
> 

besides very minor nitpicks: looks good to me! I like it much better than the
previous version, from an API design point of view.