[pve-devel] [PATCH qemu-server 4/6] vzdump: use 'warn' level for warranted log calls

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 1 15:24:29 CEST 2017


Switch those loginfo calls which log possible implications from info
to warn to inform the user

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 PVE/VZDump/QemuServer.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 65ca09d..ba15d48 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -207,7 +207,7 @@ sub assemble {
 	next if $found_pending; # skip all pending changes
 
 	if ($line =~ m/^unused\d+:\s*(\S+)\s*/) {
-	    $self->loginfo("skip unused drive '$1' (not included into backup)");
+	    $self->log('warn', "skip unused drive '$1' (not included into backup)");
 	    next;
 	}
 	next if $line =~ m/^lock:/ || $line =~ m/^parent:/;
@@ -230,7 +230,7 @@ sub assemble {
     }
 
     if ($found_pending) {
-	$self->loginfo("pending configuration changes found (not included into backup)");
+	$self->log('warn', "pending configuration changes found (not included into backup)");
     }
 
     PVE::Tools::file_copy($firewall_src, $firewall_dest) if -f $firewall_src;
@@ -503,7 +503,7 @@ sub archive {
 
     if ($err) {
 	$self->logerr($err);
-	$self->loginfo("aborting backup job");
+	$self->log('warn', "aborting backup job");
 	eval { PVE::QemuServer::vm_mon_cmd($vmid, 'backup-cancel'); };
 	if (my $err1 = $@) {
 	    $self->logerr($err1);
@@ -519,7 +519,7 @@ sub archive {
 		$self->loginfo("stopping kvm after backup task");
 		PVE::QemuServer::vm_stop($self->{storecfg}, $vmid, $skiplock);
 	    } else {
-		$self->loginfo("kvm status changed after backup ('$status')" .
+		$self->log('warn', "kvm status changed after backup ('$status')" .
 			       " - keep VM running");
 	    }
 	}
-- 
2.11.0





More information about the pve-devel mailing list