[pve-devel] [PATCH manager 1/2] ui: pveWindowEdit: allow sane onlineHelp specification for edit windows

Emmanuel Kasper e.kasper at proxmox.com
Tue Oct 17 18:54:16 CEST 2017


On 10/17/2017 02:29 PM, Thomas Lamprecht wrote:
> instead of heuristically choosing the onlineHelp entry from our first
> item prefer the one we have in our config, if noone the fallback to
> the old heuristic.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  www/manager6/window/Edit.js | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/window/Edit.js b/www/manager6/window/Edit.js
> index 9a026683..356946ed 100644
> --- a/www/manager6/window/Edit.js
> +++ b/www/manager6/window/Edit.js
> @@ -272,10 +272,11 @@ Ext.define('PVE.window.Edit', {
>  		me.buttons = [ submitBtn, resetBtn ];
>  	}
>  
> -	if (items[0].onlineHelp) {
> +	var onlineHelp = me.onlineHelp || items[0].onlineHelp;

if you had  'onlineHelp' as a new PVE.window.Edit property, then we
should document it in the Window Edit body with a default value,
similar to other PVE enhancements we have there

// set to true if you want an Remove button (instead of Create)
isRemove: false

otherwise users of the Class can only see which it's possible to set an
onlineHelpe by looking at initComponent, which is long here





More information about the pve-devel mailing list