[pve-devel] [PATCH manager 1/8] ui: rename global 'Help' button to 'Documentation'

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Oct 17 11:47:59 CEST 2017


To make it more clear that this will always end you on the
Documentation index.

Also, multiple Help buttons which all may or may not do something
different are a bit weird/confusing - thus distinction can here be
really helpful, IMO.

We target HD ready (1280x720) as minimal target resolution where this
still fits nicely. This (or bigger) resolution is also used by our
screenshot framework for the documentation - so it also fits there.

Adapt the icon displayed to `fa-book` which resembles the one often
used for manuals and is clearer than a '?', IMO.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
Acked-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/Workspace.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 1dbc3cbd..fa27fae9 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -326,9 +326,10 @@ Ext.define('PVE.StdWorkspace', {
 			    xtype: 'pveHelpButton',
 			    hidden: false,
 			    baseCls: 'x-btn',
-			    iconCls: 'fa fa-info-circle x-btn-icon-el-default-toolbar-small ',
+			    iconCls: 'fa fa-book x-btn-icon-el-default-toolbar-small ',
 			    listenToGlobalEvent: false,
 			    onlineHelp: 'pve_documentation_index',
+			    text: gettext('Documentation'),
 			    margin: '0 5 0 0'
 			},
 			createVM, 
-- 
2.11.0




More information about the pve-devel mailing list