[pve-devel] [PATCH guest-common V2] Remove noerr form replication.

Dietmar Maurer dietmar at proxmox.com
Tue Oct 17 09:01:43 CEST 2017


This way, the whole eval{} statement makes no sense anymore?!

sub run_replication {
    my ($guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
$verbose) = @_;

    my $timeout = 2; # do not wait too long - we repeat periodically anyways
    return PVE::GuestHelpers::guest_migration_lock(
	    $jobcfg->{guest}, $timeout, $run_replication_nolock,
	    $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
$verbose);
}


> @@ -380,10 +374,9 @@ sub run_replication {
>  	my $timeout = 2; # do not wait too long - we repeat periodically anyways
>  	$volumes = PVE::GuestHelpers::guest_migration_lock(
>  	    $jobcfg->{guest}, $timeout, $run_replication_nolock,
> -	    $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
> $verbose);
> +	    $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $verbose);
>      };
>      if (my $err = $@) {
> -	return undef if $noerr;
>  	die $err;
>      }
>      return $volumes;



More information about the pve-devel mailing list