[pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Oct 16 13:48:07 CEST 2017


On 10/16/2017 01:39 PM, Wolfgang Bumiller wrote:
> On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote:
>> First two patches make adding a new services over DC->HA->Add more
>> confortable by switching out the simple VMID integer spinner with a
>> combobox grid showing more details for each VM/CT, addressing #1517
>> Third one is a small cleanup patch.
>>
>> And the rest addresses #1518.
>> We add a 'More' Button to the VM and CT Config Panel (its base panel)
>> and move all buttons which may result in config changes there.
>> After that we have separated power/migrate actions from system
>> affecting actions (clone, remove, convert to template, HA).
>>
>> Thomas Lamprecht (7):
>>   ui: add VM ComboSelector
>>   ui: ha: use vmComboSelector when adding new resource
>>   ui: ha: make vote warning shorter
>>   ui: add PVE.menu.Item
>>   ui: qemu: combine system changing buttons
>>   ui: qemu: add HA manage menu item to panel
>>   ui: lxc: add 'more' button with HA manage menu item to panel
> 
> Now we have:
> LXC:  [Start] [Shutdown] [More] [Migrate] [Console] [Help]
> VM:   [Start] [Shutdown] [Migrate] [More] [Console] [Help]
> 

The different ordering is clearly an error of mine, sorry, LXC
was intended to have the same ordering:

> LXC:  [Start] [Shutdown|Reset] [Migrate] [More] [Console] [Help]
> VM:   [Start] [Shutdown|Reset] [Migrate] [More] [Console] [Help]

> I'd rather have:
> Both: [Start] [Shutdown] [Migrate] [Console] [More] [Help]
> Because a button named 'more' should be at the end rather than somewhere
> in the middle.
> 

I initially did not want to change the position of the Console and
Help button as they are there for a long time (at least Console).

But your proposal is OK for me too, Dominik/Emanuel any opinion
on this?

If they first three patches seem OK it would be nice to get them
applied as they are independent of the later ones :)



More information about the pve-devel mailing list