[pve-devel] [PATCH ha-manager 3/3] clean up 'Data::Dumper' usage tree wide

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 11 15:10:20 CEST 2017


Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 src/PVE/API2/HA/Groups.pm      | 1 -
 src/PVE/API2/HA/Resources.pm   | 1 -
 src/PVE/CLI/ha_manager.pm      | 1 -
 src/PVE/HA/FenceConfig.pm      | 1 -
 src/PVE/HA/Groups.pm           | 1 -
 src/PVE/HA/LRM.pm              | 1 -
 src/PVE/HA/Manager.pm          | 1 -
 src/PVE/HA/NodeStatus.pm       | 1 -
 src/PVE/HA/Resources.pm        | 1 -
 src/PVE/HA/Sim/Env.pm          | 1 -
 src/PVE/HA/Sim/Hardware.pm     | 1 -
 src/PVE/HA/Sim/RTEnv.pm        | 1 -
 src/PVE/HA/Sim/TestEnv.pm      | 1 -
 src/PVE/HA/Sim/TestHardware.pm | 1 -
 src/PVE/Service/pve_ha_crm.pm  | 1 -
 src/PVE/Service/pve_ha_lrm.pm  | 1 -
 src/test/test_failover1.pl     | 2 --
 17 files changed, 18 deletions(-)

diff --git a/src/PVE/API2/HA/Groups.pm b/src/PVE/API2/HA/Groups.pm
index 90fc436..820e893 100644
--- a/src/PVE/API2/HA/Groups.pm
+++ b/src/PVE/API2/HA/Groups.pm
@@ -2,7 +2,6 @@ package PVE::API2::HA::Groups;
 
 use strict;
 use warnings;
-use Data::Dumper;
 
 use PVE::SafeSyslog;
 use PVE::Tools qw(extract_param);
diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
index d57824b..47c34cd 100644
--- a/src/PVE/API2/HA/Resources.pm
+++ b/src/PVE/API2/HA/Resources.pm
@@ -12,7 +12,6 @@ use HTTP::Status qw(:constants);
 use Storable qw(dclone);
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::RPCEnvironment;
-use Data::Dumper;
 
 use PVE::RESTHandler;
 
diff --git a/src/PVE/CLI/ha_manager.pm b/src/PVE/CLI/ha_manager.pm
index 44d7bf2..48a4f4b 100644
--- a/src/PVE/CLI/ha_manager.pm
+++ b/src/PVE/CLI/ha_manager.pm
@@ -2,7 +2,6 @@ package PVE::CLI::ha_manager;
 
 use strict;
 use warnings;
-use Data::Dumper;
 
 use PVE::INotify;
 use JSON;
diff --git a/src/PVE/HA/FenceConfig.pm b/src/PVE/HA/FenceConfig.pm
index 5d898d5..ed68bca 100644
--- a/src/PVE/HA/FenceConfig.pm
+++ b/src/PVE/HA/FenceConfig.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 use PVE::Tools;
 use PVE::Cluster qw(cfs_register_file cfs_read_file cfs_write_file);
-use Data::Dumper;
 
 sub parse_config {
     my ($fn, $raw) = @_;
diff --git a/src/PVE/HA/Groups.pm b/src/PVE/HA/Groups.pm
index 8c84f7c..4816f3e 100644
--- a/src/PVE/HA/Groups.pm
+++ b/src/PVE/HA/Groups.pm
@@ -3,7 +3,6 @@ package PVE::HA::Groups;
 use strict;
 use warnings;
 
-use Data::Dumper;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::SectionConfig;
 use PVE::HA::Tools;
diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 98055ba..49e9f68 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -4,7 +4,6 @@ package PVE::HA::LRM;
 
 use strict;
 use warnings;
-use Data::Dumper;
 use POSIX qw(:sys_wait_h);
 
 use PVE::SafeSyslog;
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 7b11be4..bbcf5e7 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 use Digest::MD5 qw(md5_base64);
 
-use Data::Dumper;
 use PVE::Tools;
 use PVE::HA::Tools ':exit_codes';
 use PVE::HA::NodeStatus;
diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm
index b99689c..7e6e317 100644
--- a/src/PVE/HA/NodeStatus.pm
+++ b/src/PVE/HA/NodeStatus.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use JSON;
-use Data::Dumper;
 
 my $fence_delay = 60;
 
diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
index 3a3746e..c011176 100644
--- a/src/PVE/HA/Resources.pm
+++ b/src/PVE/HA/Resources.pm
@@ -3,7 +3,6 @@ package PVE::HA::Resources;
 use strict;
 use warnings;
 
-use Data::Dumper;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::SectionConfig;
 use PVE::HA::Tools;
diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm
index fce688a..e00b2b1 100644
--- a/src/PVE/HA/Sim/Env.pm
+++ b/src/PVE/HA/Sim/Env.pm
@@ -3,7 +3,6 @@ package PVE::HA::Sim::Env;
 use strict;
 use warnings;
 use POSIX qw(strftime EINTR);
-use Data::Dumper;
 use JSON;
 use IO::File;
 use Fcntl qw(:DEFAULT :flock);
diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 298c3bb..605a7cd 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -9,7 +9,6 @@ package PVE::HA::Sim::Hardware;
 use strict;
 use warnings;
 use POSIX qw(strftime EINTR);
-use Data::Dumper;
 use JSON; 
 use IO::File;
 use Fcntl qw(:DEFAULT :flock);
diff --git a/src/PVE/HA/Sim/RTEnv.pm b/src/PVE/HA/Sim/RTEnv.pm
index af2b46d..7f13d0b 100644
--- a/src/PVE/HA/Sim/RTEnv.pm
+++ b/src/PVE/HA/Sim/RTEnv.pm
@@ -3,7 +3,6 @@ package PVE::HA::Sim::RTEnv;
 use strict;
 use warnings;
 use POSIX qw(strftime EINTR);
-use Data::Dumper;
 use JSON; 
 use IO::File;
 use Fcntl qw(:DEFAULT :flock);
diff --git a/src/PVE/HA/Sim/TestEnv.pm b/src/PVE/HA/Sim/TestEnv.pm
index 0e6eced..9414cff 100644
--- a/src/PVE/HA/Sim/TestEnv.pm
+++ b/src/PVE/HA/Sim/TestEnv.pm
@@ -3,7 +3,6 @@ package PVE::HA::Sim::TestEnv;
 use strict;
 use warnings;
 use POSIX qw(strftime EINTR);
-use Data::Dumper;
 use JSON; 
 use IO::File;
 use Fcntl qw(:DEFAULT :flock);
diff --git a/src/PVE/HA/Sim/TestHardware.pm b/src/PVE/HA/Sim/TestHardware.pm
index 57531c5..37046b4 100644
--- a/src/PVE/HA/Sim/TestHardware.pm
+++ b/src/PVE/HA/Sim/TestHardware.pm
@@ -9,7 +9,6 @@ package PVE::HA::Sim::TestHardware;
 use strict;
 use warnings;
 use POSIX qw(strftime EINTR);
-use Data::Dumper;
 use JSON; 
 use IO::File;
 use Fcntl qw(:DEFAULT :flock);
diff --git a/src/PVE/Service/pve_ha_crm.pm b/src/PVE/Service/pve_ha_crm.pm
index 8ea2709..8b88dcb 100644
--- a/src/PVE/Service/pve_ha_crm.pm
+++ b/src/PVE/Service/pve_ha_crm.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use PVE::Daemon;
-use Data::Dumper;
 
 use PVE::HA::Env;
 use PVE::HA::Env::PVE2;
diff --git a/src/PVE/Service/pve_ha_lrm.pm b/src/PVE/Service/pve_ha_lrm.pm
index 2e2c3fc..1d7bf8e 100644
--- a/src/PVE/Service/pve_ha_lrm.pm
+++ b/src/PVE/Service/pve_ha_lrm.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use PVE::Daemon;
-use Data::Dumper;
 
 use PVE::HA::Env;
 use PVE::HA::Env::PVE2;
diff --git a/src/test/test_failover1.pl b/src/test/test_failover1.pl
index c6eb8d8..d72617e 100755
--- a/src/test/test_failover1.pl
+++ b/src/test/test_failover1.pl
@@ -7,8 +7,6 @@ use lib '..';
 use PVE::HA::Config;
 use PVE::HA::Manager;
 
-use Data::Dumper;
-
 my $groups = PVE::HA::Config::parse_groups_config("groups.tmp", <<EOD);
 group: prefer_node1
 	nodes node1
-- 
2.11.0




More information about the pve-devel mailing list