[pve-devel] [PATCH manager v3 1/1] ui: rename global 'Help' button to 'Documentation'

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 11 09:05:56 CEST 2017


To make it more clear that this will always end you on the
Documentation index.

Also, multiple Help buttons which all may or may not do something
different are a bit weird/confusing - thus distinction can here be
really helpful, IMO.

We target HD ready (1280x720) as minimal target resolution where this
still fits nicely. This (or bigger) resolution is also used by our
screenshot framework for the documentation - so it also fits there.

Adapt the icon displayed to `fa-book` which resembles the one often
used for manuals and is clearer than a '?', IMO.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

Back to 'Documentation', my initial suggestion, as I re-checked and
could confirm that we still stay below our our minimal resolution
requirement (1280x720) for both users and screenshot framework (there,
either 1280x720 or 1280x1024 is used for full page screenshots) and
Dietmar likes it better than 'Manual', where I agree, its more fitting
and easier to translate.

 www/manager6/Workspace.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 9376cea5..f2536a05 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -326,9 +326,10 @@ Ext.define('PVE.StdWorkspace', {
 			    xtype: 'pveHelpButton',
 			    hidden: false,
 			    baseCls: 'x-btn',
-			    iconCls: 'fa fa-info-circle x-btn-icon-el-default-toolbar-small ',
+			    iconCls: 'fa fa-book x-btn-icon-el-default-toolbar-small ',
 			    listenToGlobalEvent: false,
 			    onlineHelp: 'pve_documentation_index',
+			    text: gettext('Documentation'),
 			    margin: '0 5 0 0'
 			},
 			createVM, 
-- 
2.11.0




More information about the pve-devel mailing list