[pve-devel] [PATCH manager v2 5/6] ui: merge CPUOptions into ProcessorEdit

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 5 16:06:52 CEST 2017


On 10/05/2017 03:17 PM, Thomas Lamprecht wrote:
> It seemed a bit weird that those options were in a seprate edit
> window as they affect the same backend variable and may cause
> confusion, an user may not be sure in what way they are related to
> each other, if at all.
> 
> This allows us to share the help button, the docs must be updated so
> that the moved fields are represented there.
> 
> Further we reduce the count of non common buttons from the Hardware
> View.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> changes since v1:
> * use the ViewController's init call back for enforcing what fields are
>   hidden if not in Wizard, instead of an afterrender listener on the view,
>   not only shorter it also gets called just once.
> * use 'vCPUs at start' for the vcpus field, as vCPUs is to general and would
>   suggest that this is also involved in the total core count... Another
>   option was 'Plugged vCPUs' but that sounded a bit weird, IMO.
> 

Dominik noticed me that "vCPUs at start" is not a good idea as when this gets
set during the VM is running it hot-(un)plugs vCPUs, so 'Plugged  vCPUs' would
be better.



More information about the pve-devel mailing list