[pve-devel] [PATCH manager 3/3] ui: add onlineHelpTitle to ConfigPanel childs

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 5 15:05:37 CEST 2017


Lets add a onlineHelp title for the ConfigPanel lxc, qemu, node and
pool (omitting only dc). As we fall back to the current ConfigPanels
help link when a tab (or sub panel) has no own specific help defined
this then can be shown so that the user sees which help will open
before clicking the button.
I left out datacenters config panel as it currently links to the
whole ref. documentations all in one page site and I had no good name
for that as its not a signle chapter - so its just Help.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/lxc/Config.js        | 1 +
 www/manager6/node/Config.js       | 1 +
 www/manager6/panel/ConfigPanel.js | 2 +-
 www/manager6/pool/Config.js       | 1 +
 www/manager6/qemu/Config.js       | 1 +
 5 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js
index 45ff214a..272e7588 100644
--- a/www/manager6/lxc/Config.js
+++ b/www/manager6/lxc/Config.js
@@ -3,6 +3,7 @@ Ext.define('PVE.lxc.Config', {
     alias: 'widget.PVE.lxc.Config',
 
     onlineHelp: 'chapter_pct',
+    onlineHelpTitle: gettext('Container'),
 
     initComponent: function() {
         var me = this;
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 49f1186f..6270307b 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -3,6 +3,7 @@ Ext.define('PVE.node.Config', {
     alias: 'widget.PVE.node.Config',
 
     onlineHelp: 'chapter_system_administration',
+    onlineHelpTitle: gettext('Node'),
 
     initComponent: function() {
         var me = this;
diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js
index 14478daa..5c269b6b 100644
--- a/www/manager6/panel/ConfigPanel.js
+++ b/www/manager6/panel/ConfigPanel.js
@@ -131,7 +131,7 @@ Ext.define('PVE.panel.Config', {
 	    if (newcard.onlineHelp) {
 		me.helpButton.setOnlineHelp(newcard.onlineHelp, newcard.title);
 	    } else {
-		me.helpButton.setOnlineHelp(me.onlineHelp);
+		me.helpButton.setOnlineHelp(me.onlineHelp, me.onlineHelpTitle);
 	    }
 	    if (curcard) {
 		me.setActiveItem(cardid);
diff --git a/www/manager6/pool/Config.js b/www/manager6/pool/Config.js
index fedf25b2..a304b7b2 100644
--- a/www/manager6/pool/Config.js
+++ b/www/manager6/pool/Config.js
@@ -3,6 +3,7 @@ Ext.define('PVE.pool.Config', {
     alias: 'widget.pvePoolConfig',
 
     onlineHelp: 'pveum_pools',
+    onlineHelpTitle: gettext('Pool'),
 
     initComponent: function() {
         var me = this;
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index fb329fc8..2b9a1b62 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -3,6 +3,7 @@ Ext.define('PVE.qemu.Config', {
     alias: 'widget.PVE.qemu.Config',
 
     onlineHelp: 'chapter_virtual_machines',
+    onlineHelpTitle: gettext('Virtual Machine'),
 
     initComponent: function() {
         var me = this;
-- 
2.11.0




More information about the pve-devel mailing list