[pve-devel] [PATCH guest-common] Send email when a replication job fails.

[Philip Abernethy]

On Tue, Oct 03, 2017 at 11:42:03AM +0200, Wolfgang Link wrote:
> > Philip Abernethy <p.abernethy at proxmox.com> hat am 3. Oktober 2017 um 10:20 geschrieben:
> > 
> > 
> > On Tue, Oct 03, 2017 at 09:55:06AM +0200, Wolfgang Link wrote:
> > > A email notification will be send for each job when the job fails.
> > > This message will continued as long the job is failing.
> > > ---
> > >  PVE/Replication.pm | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/PVE/Replication.pm b/PVE/Replication.pm
> > > index e53928e..0075b45 100644
> > > --- a/PVE/Replication.pm
> > > +++ b/PVE/Replication.pm
> > > @@ -358,7 +358,10 @@ my $run_replication_nolock = sub {
> > >  
> > >  	close($logfd);
> > >  
> > > -	die $err if $err && !$noerr;
> > > +	if ($err) {
> > > +	    PVE::Tools::sendmail('root at localhost', "Replication Job: $jobcfg->{id} failed", $err);
> > Please use 'root' instead of 'root at localhost'. This allows postfix to
> > fill in the proper FQDN itself, resulting in a more useful sender
> > address.
> 
> As far I understand the Doku of Postfix and virtual 
> 'root' and 'root at localhost' are the same.
Not quite. Our postfix is configured to insert the configured FQDN if no
domain is present on the address.
So while both will be delivered to root at localhost and forwarded to the
user configured in the datacenter, using 'root at localhost' results in
this be the sender address, while using 'root' results in the sender
address being root@<host.domain.tld>, where <host.domain.tld> obviously
is the sending node's FQDN as configured during installation, which I
deem more informational and helpful than 'root at localhost'.
Also see my patch on that topic.
> http://www.postfix.org/STANDARD_CONFIGURATION_README.html#some_local
> man 5 virtual