[pve-devel] applied: [PATCH cluster 1/2] cfs_lock: add missing trailing newline

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Nov 10 11:31:00 CET 2017


applied

On Fri, Nov 10, 2017 at 10:24:24AM +0100, Thomas Lamprecht wrote:
> When we do not instantly get the lock we print a respective message
> to stderr. This shows also up in the task logs, and if it's the last
> message before a 'Task OK' the UI gets confused an shows the task as
> erroneous.
> 
> Keep the message as its a good feedback for the user to see why an op
> seems to do nothing, so simply add a trailing newline.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  data/PVE/Cluster.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
> index 21c1f13..e248f7f 100644
> --- a/data/PVE/Cluster.pm
> +++ b/data/PVE/Cluster.pm
> @@ -890,7 +890,7 @@ my $cfs_lock = sub {
>  
>  	    $timeout_err->() if $timeout <= 0;
>  
> -	    print STDERR "trying to aquire cfs lock '$lockid' ...";
> +	    print STDERR "trying to aquire cfs lock '$lockid' ...\n";
>  	    utime (0, 0, $filename); # cfs unlock request
>  	    sleep(1);
>  	}
> -- 
> 2.11.0




More information about the pve-devel mailing list