[pve-devel] [PATCH manager v4 0/8] improve tree icons

[Thomas Lamprecht]

On 11/03/2017 09:51 AM, Dominik Csapak wrote:
> this series aims to give better feedback with the tree icons to the user
> especially in regard to corosync online/offline and rrdstats
>> changes since v3:
>  * add info if storage is (near)full
>  * if we have information, the status is now 'available' instead of ''
>  * new css classes for (neaf)full storages
>  * new cleanup patch
> 
> changes since v2:
>  * change the default status for storage to unknown and add an explaining
>    comment
>  * optimize css classes
>  * optimize icon calculation
> 
> changes since v1:
>  * generate the status field on the backend instead online/active
>  * add a default 'unknown' status for vm/ct
> 
> Dominik Csapak (8):
>   add status to node stats
>   include a 'status' field for storages
>   add default 'unknown' status for vms and containers
>   add a new status column in the resourcestore
>   add new tree and grid classes for the 'unknown' status
>   improve tree/grid icons
>   whitespace cleanup
>   remove unecessary semicolons
> 
>  PVE/API2Tools.pm                   |  23 ++++++-
>  www/css/ext6-pve.css               | 133 ++++++++++++++++---------------------
>  www/manager6/Utils.js              |  64 ++++++++----------
>  www/manager6/data/ResourceStore.js |   7 ++
>  www/manager6/tree/ResourceTree.js  |  57 ++++------------
>  5 files changed, 124 insertions(+), 160 deletions(-)
> 
I really like it in general not only the visual changes but also css cleanups.

What I noticed is that non-existing nodes (the ones that are no-where referred
to, but it's /etc/pve/nodes directory exists with a VM/CT config) are shown
different now, see the resource tree:

prev: https://i.imgur.com/ppV4k9b.png
vs
now: https://i.imgur.com/mqLW4nj.png