[pve-devel] [PATCH storage 1/3] add select to plugindata for iscsi(direct)

[Thomas Lamprecht]

On 11/08/2017 10:53 AM, Dominik Csapak wrote:
> this will be used in the gui, for determining if we need to select
> something from the storage when using for an image
> 

Sorry, I did not understand this completely by just reading the
commit message and looking at the diff.
Also, a bit more self-describing name would be nice for the
'select' property, IMO. AFAICT, it means that there must be
selected an already existing image instead of creating one, or?
An API user has no idea what select could mean here in this
context. Maybe:

no_auto_create
select_existing


far from perfect, but a bit better than just select IMO, maybe
you got even a better idea.

Besides that this looks good.

> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/Storage/ISCSIDirectPlugin.pm | 3 ++-
>  PVE/Storage/ISCSIPlugin.pm       | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/ISCSIDirectPlugin.pm b/PVE/Storage/ISCSIDirectPlugin.pm
> index f0c6c53..dad9436 100644
> --- a/PVE/Storage/ISCSIDirectPlugin.pm
> +++ b/PVE/Storage/ISCSIDirectPlugin.pm
> @@ -56,7 +56,8 @@ sub type {
>  
>  sub plugindata {
>      return {
> -        content => [ {images => 1, none => 1}, { images => 1 }],
> +	content => [ {images => 1, none => 1}, { images => 1 }],
> +	select => 1,
>      };
>  }
>  
> diff --git a/PVE/Storage/ISCSIPlugin.pm b/PVE/Storage/ISCSIPlugin.pm
> index aef8675..f75a8d9 100644
> --- a/PVE/Storage/ISCSIPlugin.pm
> +++ b/PVE/Storage/ISCSIPlugin.pm
> @@ -237,6 +237,7 @@ sub type {
>  sub plugindata {
>      return {
>  	content => [ {images => 1, none => 1}, { images => 1 }],
> +	select => 1,
>      };
>  }
>  
>