[pve-devel] [RFC common 0/9] respinned: sub command for CLI helper

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 6 14:54:45 CET 2017


I picked up Philips sub command patch, tried to split it up in
digestible chunks, refactored a few things and tried to address the
open comments from my last review where this series was still owned by
Philip.
I'm at the point where I a looked at the code a bit to long without
getting inspiration to further simplify this, so it would be nice if
someone else can take a look at it and give me feedback. I tried to
keep the single patches self-sustaining as far as possible, nothing
_should_ break between them, but as a few rebase cycles happened it
could be that I overlooked something.

cheers,
Thomas

Thomas Lamprecht (9):
  cli: refactor and use $cmddef directly
  cli: factor out initialisation check
  cli: refactor comand name helper
  cli: refactor print_bash_completion
  cli: factor out abort
  cli: factor out generate usage string
  cli: allow specifying sub commands through $cmddef
  cli: allow to pass sub commands to help as array
  cli: document $cmddef structure

 src/PVE/CLIHandler.pm | 385 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 230 insertions(+), 155 deletions(-)

-- 
2.11.0





More information about the pve-devel mailing list