[pve-devel] [PATCH v2 pve-manager 20/22] PVE::Replication - aquire guest_migration_lock during replication

Dominik Csapak d.csapak at proxmox.com
Mon May 29 13:42:29 CEST 2017


On 05/29/2017 11:30 AM, Dietmar Maurer wrote:
> To block guest migration.
>
> Signed-off-by: Dietmar Maurer <dietmar at proxmox.com>
> ---
>  PVE/Replication.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Replication.pm b/PVE/Replication.pm
> index a3bbc322..3f1072d0 100644
> --- a/PVE/Replication.pm
> +++ b/PVE/Replication.pm
> @@ -11,6 +11,7 @@ use PVE::ProcFSTools;
>  use PVE::Tools;
>  use PVE::CalendarEvent;
>  use PVE::Cluster;
> +use PVE::AbstractConfig;
>  use PVE::QemuConfig;
>  use PVE::QemuServer;
>  use PVE::LXC::Config;
> @@ -388,7 +389,12 @@ my $run_replication = sub {
>
>      $logfunc->($start_time, "$jobcfg->{id}: start replication job") if $logfunc;
>
> -    eval { replicate($jobcfg, $state->{last_sync}, $start_time, $logfunc); };
> +    eval {
> +	my $timeout = 2; # do not wait too long - we repeat periodically anyways
> +	PVE::AbstractConfig::guest_migration_lock(
> +	    $jobcfg->{guest}, $timeout, \&replicate,
> +	    $jobcfg, $state->{last_sync}, $start_time, $logfunc);
> +    };
>      my $err = $@;
>
>      $state->{duration} = tv_interval($t0);
>


is there a patch for pve-guest-common missing?
i cannot get this series to compile because of:

Undefined subroutine &PVE::AbstractConfig::guest_migration_lock called 
at ../../PVE/Replication.pm line 396

(current master of pve-guest-common + last 2 patches from 2017-05-23)




More information about the pve-devel mailing list