[pve-devel] [PATCH manager 3/3] add more verbose warning for node shutdown/reboot

Emmanuel Kasper e.kasper at proxmox.com
Wed May 24 12:16:39 CEST 2017


On 05/12/2017 12:14 PM, Thomas Lamprecht wrote:
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> I'm open for better warning message suggestions :-)

I would reuse the already localized gettext String "Stop all VMs and
Containers".

There was the bug report #1095 which you can close with your commit.

ACK for the rest.

>  www/manager6/node/Config.js | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
> index be3393bb..e1f2a69f 100644
> --- a/www/manager6/node/Config.js
> +++ b/www/manager6/node/Config.js
> @@ -84,7 +84,8 @@ Ext.define('PVE.node.Config', {
>  	    text: gettext('Restart'),
>  	    disabled: !caps.nodes['Sys.PowerMgmt'],
>  	    dangerous: true,
> -	    confirmMsg: gettext('Node') + " '" + nodename + "' - " + gettext('Restart'),
> +	    confirmMsg: gettext('Node') + " '" + nodename + "' - " + gettext('Restart')
> +		+ '<br /><br />' + gettext('Powers off all VMs and CTs!'),
>  	    handler: function() {
>  		node_command('reboot');
>  	    },
> @@ -95,7 +96,8 @@ Ext.define('PVE.node.Config', {
>  	    text: gettext('Shutdown'),
>  	    disabled: !caps.nodes['Sys.PowerMgmt'],
>  	    dangerous: true,
> -	    confirmMsg: gettext('Node') + " '" + nodename + "' - " + gettext('Shutdown'),
> +	    confirmMsg: gettext('Node') + " '" + nodename + "' - " + gettext('Shutdown')
> +		+ '<br /><br />' + gettext('Powers off all VMs and CTs!'),
>  	    handler: function() {
>  		node_command('shutdown');
>  	    },
> 




More information about the pve-devel mailing list