[pve-devel] [PATCH storage] migrate: snapshot parameter for use with replication

[Wolfgang Bumiller]

> > On May 22, 2017 at 10:16 AM Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
> > 
> > 
> > ---
> >  PVE/Storage.pm | 31 ++++++++++++++++++++++---------
> >  1 file changed, 22 insertions(+), 9 deletions(-)
> > 
> > diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> > index 5819bde..73f2976 100755
> > --- a/PVE/Storage.pm
> > +++ b/PVE/Storage.pm
> > @@ -525,7 +525,7 @@ sub abs_filesystem_path {
> >  }
> >  
> >  sub storage_migrate {
> > -    my ($cfg, $volid, $target_host, $target_storeid, $target_volname,
> > $base_snapshot) = @_;
> > +    my ($cfg, $volid, $target_host, $target_storeid, $target_volname,
> > $base_snapshot, $snapshot) = @_;

On Mon, May 22, 2017 at 12:47:58PM +0200, Dietmar Maurer wrote:
> Can we use get_ssh_info() here?

I would send that as a separate patch. $target_host would be replaced by
an ssh info hash. (The call to get_ssh_info() is up to the callers
here).