[pve-devel] [PATCH novnc 0/3] upgrade noVNC

[Thomas Lamprecht]

Hi,

On 05/11/2017 04:21 PM, Dominik Csapak wrote:
> Hi,
>
> Did you apply my patch for pve-http-server that I sent today?
> I should have written that that patch is a requirement for this series.
>
> If you have, did you empty your browser cache?

As stated in my other mail, yes, but only the http-server patch fixed it.
Everything is working for now (did just basic testing until now, though)

I guess that Firefox just had some images in the cache from last time I 
tested the new noVNC on your host ^^

cheers,
Thomas

>
> On May 11, 2017 3:51 PM, "Thomas Lamprecht" <t.lamprecht at proxmox.com> wrote:
>
>> Tested a bit, for now the only problem I saw is that with Chromium the
>> noVNC buttons have a "missing" image.
>> Did a full reload with emptied cache, not change.
>> It looks like: https://www.pictshare.net/oqwzh57aj3.png
>>
>> Firefox works just as expected, so the installation should be good.
>>
>>
>> On 05/11/2017 01:42 PM, Dominik Csapak wrote:
>>
>>> this series upgrades noVNC to the latest master, and
>>> improves our code a bit
>>>
>>> a few notes:
>>> * before building a 'make download' is required
>>> (i want to change this repo to use submodules in the future)
>>> * the version is 0.6-1 because this is the last upstream release,
>>>     but we use the latest master, which had many improvements
>>>
>>> notable changes (from user perspective):
>>> * you can now use fullscreen from a popup
>>> * when a vm changes resolution, the console tab should resize
>>> automatically
>>> * removed our "extra keys" menu in favor of the one in novnc
>>>     (this can do everything we could)
>>> * better handling of restart migration of lxc
>>>     (we now poll the status until the migration is finished)
>>>
>>> Please Test!
>>> Altough i have tested the changes, i probably did not test everything ;)
>>>
>>>
>>> Dominik Csapak (3):
>>>     add rebased patches
>>>     upgrade novnc
>>>     remove old unused patches
>>>
>>>    Makefile                                           |   9 +-
>>>    debian/changelog                                   |   6 +
>>>    debian/install                                     |  30 +-
>>>    debian/patches/0001-add-pve-specific-js-code.patch | 637 ++++++++++++++
>>>    ...2-change-scaling-when-toggling-fullscreen.patch |  45 +
>>>    debian/patches/0003-add-pve-style.patch            |  75 ++
>>>    debian/patches/0004-remove-vnc-logos.patch         |  54 ++
>>>    ...-change-src-directory-for-images-js-files.patch | 217 +++++
>>>    debian/patches/0006-add-pve-vnc-commands.patch     |  44 +
>>>    ...0007-add-replaceable-snippets-in-vnc.html.patch |  41 +
>>>    debian/patches/0008-focus-canvas-after-load.patch  |  43 +
>>>    debian/patches/0009-decrease-animation-time.patch  |  73 ++
>>>    debian/patches/customize-html-tpl.diff             | 207 -----
>>>    debian/patches/fix-CtrlAltDel-button-mobile.patch  |  18 -
>>>    debian/patches/fix-base-css.patch                  | 195 -----
>>>    debian/patches/fix-ie11-resize.patch               |  11 -
>>>    .../fix-websocket-binary-support-test.patch        |  13 -
>>>    debian/patches/pveui.patch                         | 912
>>> ---------------------
>>>    debian/patches/series                              |  14 +-
>>>    debian/rules                                       |   6 +
>>>    20 files changed, 1260 insertions(+), 1390 deletions(-)
>>>    create mode 100644 debian/patches/0001-add-pve-specific-js-code.patch
>>>    create mode 100644 debian/patches/0002-change-sca
>>> ling-when-toggling-fullscreen.patch
>>>    create mode 100644 debian/patches/0003-add-pve-style.patch
>>>    create mode 100644 debian/patches/0004-remove-vnc-logos.patch
>>>    create mode 100644 debian/patches/0005-change-src
>>> -directory-for-images-js-files.patch
>>>    create mode 100644 debian/patches/0006-add-pve-vnc-commands.patch
>>>    create mode 100644 debian/patches/0007-add-replac
>>> eable-snippets-in-vnc.html.patch
>>>    create mode 100644 debian/patches/0008-focus-canvas-after-load.patch
>>>    create mode 100644 debian/patches/0009-decrease-animation-time.patch
>>>    delete mode 100644 debian/patches/customize-html-tpl.diff
>>>    delete mode 100644 debian/patches/fix-CtrlAltDel-button-mobile.patch
>>>    delete mode 100644 debian/patches/fix-base-css.patch
>>>    delete mode 100644 debian/patches/fix-ie11-resize.patch
>>>    delete mode 100644 debian/patches/fix-websocket-b
>>> inary-support-test.patch
>>>    delete mode 100644 debian/patches/pveui.patch
>>>
>>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at pve.proxmox.com
>> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel