[pve-devel] [PATCH manager 3/6] add a new status column in the resourcestore

Dominik Csapak d.csapak at proxmox.com
Wed May 3 09:11:27 CEST 2017


On 05/03/2017 07:07 AM, Dietmar Maurer wrote:
> This looks quite clumsy. Can't we compute a reasonable status at
> the server side?

yes, we can, but i would want to only calculate 'known' statuses in the 
backend (online,running,etc.) and keep the implicit 'unknown' in the 
frontend (in case we ever hit an case where from the backend comes an 
empty status instead of a valid one)

i will send a v2 of the series

>
> Why do you use different names like 'online', 'active' and 'status'?

running,online,active are booleans and status is the textual 
representation of the status

as for the different names:

a vm/ct can be running/stopped/paused/etc.

but for a node, running/stopped makes no sense, as we do not know why we 
cannot reach it, therefore online/offline makes more sense

and storages are in our backend active or not active (as seen e.g. in 
the activate_storage subs), also here running,online, etc. do not really 
make sense

>
> Also, the 'running' field contains similar information? Can we
> merge that somehow?
>

since running is a boolean which does not fully represent the status,
i would leave that seperate




More information about the pve-devel mailing list