[pve-devel] [PATCH container] Proposed fix for #1326: Added secondary server to graphite plugin as secondary_server parameter. It may be required if graphite data needs to be mirrored as in the case here. Carbon-relay is too much...

[Pavel Andreev]

Hi Dominik,
>
> 1. Did you read the http://pve.proxmox.com/wiki/Developer_Documentation ?
> specially the part about the license and the Harmony CLA?
> if not, please do so
>
yes, I did.

> 2. Git styling
> Please try and keep the subject short and precise,
> you can write a longer text in the commit message
> the format is
>
> subject of the commit
>
> longer text of the commit
> with multiple lines
>
> also if you write "fix #1326" instead of "fix for #1326" our tools can 
> detect the patch, and
> update the bugtracker semi-automatically

missed that, sorry.
>
> 3. Content
> The idea in general is very good, but there is a better approach
> instead of hardcoding a second server in the graphite plugin,
> it would be better to allow defining multiple servers of each type
> (so it would work also with influxdb)
>
> the changes would be in PVE/Status/Plugin.pm
> where we parse the header section,
> here we use the type also as name, but this
> can be (backwards compatible) changed so that
> you can give the entries names
>
> this would be automatically used in the code
> and sent to each one
>
> for an example how to write the parser
> see PVE/Storage/Plugin.pm
>
> in the pve-storage package
>
> i also could send this patches for you if you only want the feature and
> do not care about that you contributed to the code

I thought of this approach and even looked exactly to the Storage code 
and the header section but seemed to me my fix is simpler.
Would you be able to advise a bit further how to give the entries names?

Thank you,

Pavel