[pve-devel] [PATCH manager] fix start on boot

[Thomas Lamprecht]

On 03/24/2017 08:58 AM, Fabian Grünbichler wrote:
> fix the fix for #1024
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> @Thomas: this seems to fix the immediate issues as reported on the forum,
> but could you please check the rest of this refactoring as well?

ugh, that happens if you have uncommitted code lying around... :/

Yes, this fixes the problems.
Just for the record this is not a "fix for the #1024 fix" but for an
previous refactoring patch which wasn't complete, namely:

commit 627fa10467a1578c5a3c7d2a292bbe6f14a881ca
Author: Thomas Lamprecht <t.lamprecht at proxmox.com>
Date:   Wed Mar 15 16:47:41 2017 +0100

     get_filtered_vmlist: save VM conf in own subhash


thanks for fixing,
cheers,

Thomas

>
>   PVE/API2/Nodes.pm | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index 03f97bf..a45ca6d 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -1281,7 +1281,7 @@ my $get_start_stop_list = sub {
>   	$startup->{order} = LONG_MAX if !defined($startup->{order});
>   
>   	$resList->{$startup->{order}}->{$vmid} = $startup;
> -	$resList->{$startup->{order}}->{$vmid}->{type} = $conf->{type};
> +	$resList->{$startup->{order}}->{$vmid}->{type} = $vmlist->{$vmid}->{type};
>       }
>   
>       return $resList;
> @@ -1294,7 +1294,7 @@ my $remove_locks_on_startup = sub {
>   
>       foreach my $vmid (keys %$vmlist) {
>   	my $conf = $vmlist->{$vmid}->{conf};
> -	my $class = $conf->{class};
> +	my $class = $vmlist->{$vmid}->{class};
>   
>   	eval {
>   	    if ($class->has_lock($conf, 'backup')) {