[pve-devel] [PATCH manager v2 1/2] Add a new renderer for displaying dates in a human readable way

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Mar 13 12:52:03 CET 2017


While writing the change log I was wondering why you chose a specific
format there. Isn't there a way to tell the browser to give you a locale
dependent somewhat sane format? Otherwise why care?

On Tue, Jan 31, 2017 at 04:48:49PM +0100, Emmanuel Kasper wrote:
> render_timestamp returns a Date as
> "2017-01-31 16:17:33"
> which is good for computers and column sorting but unfit
> for human consumption
> 
> the new renderer added by this patch renders a Date as
> "Tuesday 31 January 2017 16:18:08"
> 
> Day-month-year order is the most used ordering
> in the world and also commonly used in the USA for
> official documents.
> source:
> https://en.wikipedia.org/wiki/Date_and_time_notation_in_the_United_States
> https://en.wikipedia.org/wiki/Date_format_by_country
> ---
>  www/manager6/Utils.js | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index c05a137..148a122 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -913,6 +913,10 @@ Ext.define('PVE.Utils', { utilities: {
>  	return Ext.Date.format(servertime, 'Y-m-d H:i:s');
>      },
>  
> +    render_timestamp_human_readable: function(value) {
> +	return Ext.Date.format(new Date(value * 1000), 'l d F Y H:i:s');
> +    },
> +
>      calculate_mem_usage: function(data) {
>  	if (!Ext.isNumeric(data.mem) ||
>  	    data.maxmem === 0 ||
> -- 
> 2.1.4




More information about the pve-devel mailing list