[pve-devel] [PATCH manager] correctly set 'nowritecache' on zfsplugin

[Michael Rasmussen]

On Tue, 7 Mar 2017 19:38:38 +0100 (CET)
Dietmar Maurer <dietmar at proxmox.com> wrote:

> > +		    // reverse the logic for the checkbox
> > +		    values.nowritecache = values.nowritecache == '0'?'1':'0';  
> 
> I wonder why we compare to a string '0'?? AFAIK nowritecache is an
> boolean/integer?
> 
The reason for this is that the API returns a string. Eg.
values.nowritecache is a string and not an integer/boolean.

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------
/usr/games/fortune -es says:
My doctorate's in Literature, but it seems like a pretty good pulse to
me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20170307/b7846714/attachment.sig>