[pve-devel] [PATCH manager] add css fix for chrome >=56

Emmanuel Kasper e.kasper at proxmox.com
Thu Mar 2 09:55:28 CET 2017


LGTM but can we include a link in the commit log to the sencha forum
post discussing the issue ?

On 03/02/2017 08:45 AM, Dominik Csapak wrote:
> with chrome/chromium version 56, they changed the way how they calculate
> height of text in input fields (now it is correct according to the
> standard) but extjs up to 6.2.1 has a fix for this in css
> 
> this patch reverses the fix in extjs and can be reverted when they
> remove the fix upstream
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> according to various online browser statistic sites, chrome version adaption
> takes around 1 to 2 months, and version 56 is out since end of january,
> so it would be good to have this fix in the enterprise repo until end of march
>  www/css/ext6-pve.css | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
> index 083cc42..f42e935 100644
> --- a/www/css/ext6-pve.css
> +++ b/www/css/ext6-pve.css
> @@ -508,3 +508,12 @@ table.osds td:first-of-type {
>      font-style: italic;
>      font-weight: bold;
>  }
> +
> +/* chrome 56 fix */
> +.x-webkit .x-form-text {
> +    height: 100% !important;
> +}
> +
> +.x-webkit :not(.x-form-textarea-body) > .x-form-trigger-wrap {
> +    height: initial;
> +}
> 




More information about the pve-devel mailing list