[pve-devel] [PATCH v7 pve-storage 02/10] Basic FreeNAS API interaction code

[Michael Rasmussen]

On Wed, 21 Jun 2017 15:58:13 +0200
Fabian Grünbichler <f.gruenbichler at proxmox.com> wrote:

> > +    die $res->code."\n" unless $res->is_success;  
> 
> this deviates from v5 - now you die with the HTTP error code, and not
> with the full status message (except for in freenas_create_target_group
> and freenas_create_target) - is this intentional?
> 

This is intentional since a need sometimes to get the status code when
it dies.

> +    foreach my $zvol (@$zvols) {
> +        next unless $zvol->{name} =~ /^(base|vm)-(\d+)-disk-\d+$/;  
> 

I cannot use parse_volname here since a pool could easily have zvols
not related to proxmox in any shape or fashion. Using parse_volname
here would make the plugin die if such zvols were found.

> custom volume names still missing here? but maybe you'll include that
> when switching to parse_volname..
> 

For the moment custom volume names is not supported. Frankly, I hardly
see the usecase?

> 
> the hack with encoding the linked clone origin relationship in a snapshot name
> still seems really really bad, but I guess there is no other way given the
> current FreeNAS API limitations. I do wonder whether it would not be better to
> skip linked clones until the API exposes this information? otherwise we have to
> keep this workaround supported forever..
> 

I intend to keep it since linked clones is a huge bonus.

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------
/usr/games/fortune -es says:
    ***
  *******
 *********
 ****** Confucious say: "Is stuffy inside fortune cookie."
  *******
    ***
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20170629/4800b75c/attachment.sig>