[pve-devel] [PATCH manager 4/5] do not let www-data own the static js/html files

Dominik Csapak d.csapak at proxmox.com
Fri Jun 9 09:55:27 CEST 2017


this is neither necessary, nor useful
those files are meant to be read only anyway, so there is no gain in
them being owned by www-data

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 po/Makefile            | 2 +-
 www/Makefile           | 2 +-
 www/css/Makefile       | 2 +-
 www/css/fonts/Makefile | 2 +-
 www/images/Makefile    | 2 +-
 www/manager6/Makefile  | 2 +-
 www/mobile/Makefile    | 1 -
 www/touch/Makefile     | 1 -
 8 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/po/Makefile b/po/Makefile
index 27735a74..68736cd4 100644
--- a/po/Makefile
+++ b/po/Makefile
@@ -21,7 +21,7 @@ pve-lang-%.js: %.po
 .PHONY: install 
 install: $(patsubst %, pve-lang-%.js, $(LINGUAS))
 	install -d ${WWWLOCALEDIR}
-	install -m 0644 -o www-data -g www-data $^ ${WWWLOCALEDIR}
+	install -m 0644 $^ ${WWWLOCALEDIR}
 
 clean:
 	rm -rf *~ *.po.tmp *.js.tmp pve-lang-*.js
diff --git a/www/Makefile b/www/Makefile
index caa387d2..30becf3a 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -9,5 +9,5 @@ all: ${SUBDIRS} index.html.tpl
 .PHONY: install
 install:
 	set -e && for i in ${SUBDIRS}; do ${MAKE} -C $$i $@; done
-	install -m 0644 -o www-data -g www-data index.html.tpl ${WWWBASEDIR}
+	install -m 0644 index.html.tpl ${WWWBASEDIR}
 
diff --git a/www/css/Makefile b/www/css/Makefile
index fd46a8c1..449f6f4f 100644
--- a/www/css/Makefile
+++ b/www/css/Makefile
@@ -5,7 +5,7 @@ all:
 .PHONY: install 
 install: ext6-pve.css font-awesome.css
 	install -d ${WWWCSSDIR}
-	install -m 0644 -o www-data -g www-data $? ${WWWCSSDIR}
+	install -m 0644 $? ${WWWCSSDIR}
 	set -e && ${MAKE} -C fonts install
 
 .PHONY: clean
diff --git a/www/css/fonts/Makefile b/www/css/fonts/Makefile
index b14d3422..d957edce 100644
--- a/www/css/fonts/Makefile
+++ b/www/css/fonts/Makefile
@@ -5,7 +5,7 @@ all:
 .PHONY: install 
 install: README fontawesome-webfont.ttf FontAwesome.otf fontawesome-webfont.woff2 fontawesome-webfont.svg fontawesome-webfont.woff fontawesome-webfont.eot
 	install -d ${WWWFONTSDIR}
-	install -m 0644 -o www-data -g www-data $? ${WWWFONTSDIR}
+	install -m 0644 $? ${WWWFONTSDIR}
 
 .PHONY: clean
 clean:
diff --git a/www/images/Makefile b/www/images/Makefile
index dcb48e53..c5752962 100644
--- a/www/images/Makefile
+++ b/www/images/Makefile
@@ -71,7 +71,7 @@ IMAGES = ${GNOME_IMAGES}	\
 .PHONY: install 
 install: ${IMAGES}
 	install -d ${WWWIMAGEDIR}
-	install -m 0644 -o www-data -g www-data ${IMAGES} ${WWWIMAGEDIR}
+	install -m 0644 ${IMAGES} ${WWWIMAGEDIR}
 
 .PHONY: clean
 clean:
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 0c266ef7..3a8121a1 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -233,7 +233,7 @@ all: pvemanagerlib.js
 install: pvemanagerlib.js
 	install -d ${WWWBASEDIR}/root
 	install -d ${WWWJSDIR}
-	install -m 0644 -o www-data -g www-data pvemanagerlib.js ${WWWJSDIR}
+	install -m 0644 pvemanagerlib.js ${WWWJSDIR}
 
 .PHONY: clean
 clean:
diff --git a/www/mobile/Makefile b/www/mobile/Makefile
index 1947e76b..cd0290ad 100644
--- a/www/mobile/Makefile
+++ b/www/mobile/Makefile
@@ -35,7 +35,6 @@ pvemanager-mobile.js: ${JSSRC}
 install: pvemanager-mobile.js
 	install -d ${WWWTOUCHDIR}
 	install -m 0644 pvemanager-mobile.js ${WWWTOUCHDIR}
-	chown -R www-data:www-data ${WWWTOUCHDIR}
 
 .PHONY: clean
 clean:
diff --git a/www/touch/Makefile b/www/touch/Makefile
index 2291ce29..846b76ad 100644
--- a/www/touch/Makefile
+++ b/www/touch/Makefile
@@ -24,7 +24,6 @@ install: ${TOUCHDATA} index.html.tpl
 	install -m 0644 index.html.tpl ${WWWTOUCHDIR}
 	install -d ${WWWTOUCHDIR}/resources/themes/images
 	cp -a ${TOUCHDIR}/resources/themes/images/default ${WWWTOUCHDIR}/resources/themes/images
-	chown -R www-data:www-data ${WWWTOUCHDIR}
 	find ${WWWTOUCHDIR} -type f -exec chmod -R 0644 '{}' ';'
 
 .PHONY: clean
-- 
2.11.0





More information about the pve-devel mailing list