[pve-devel] Problems creating live snapshot

Dietmar Maurer dietmar at proxmox.com
Wed Jun 7 12:11:08 CEST 2017


We allocate the snapshot file on an active storage, so it should not 
be necessary to activate it again.

Note: see __snapshot_save_vmstate and foreach_writable_storage

> But I have found the reason anyway.
> savevm-start calls the path function of the storage which in case 
> returns a means for savevm-start to access the vm state disk which is 
> all as should be. However, I have discovered that savevm-start does not 
> call the storage function activate_volume neither prior nor after the 
> call to the function path. This leads to the following questions:
> 1) Should a call to path in a storage plugin always implicitly have the 
> storage plugin activate the volume?

no

> 2) Should savevm-start call the storage plugins function activate_volume 
> before or after calling path?

no




More information about the pve-devel mailing list