[pve-devel] Problems creating live snapshot

datanom.net mir at datanom.net
Wed Jun 7 11:51:23 CEST 2017


On 2017-06-07 08:52, Fabian Grünbichler wrote:
> 
> this could easily be tested by adding a sleep or udev trigger udev
> settle sequence into QemuConfig's __snapshot_create_vol_snapshots_hook,
> inside the before branch before calling savevm-start (line 185 in
> current master).
> 
This was not the problem.

But I have found the reason anyway.
savevm-start calls the path function of the storage which in case 
returns a means for savevm-start to access the vm state disk which is 
all as should be. However, I have discovered that savevm-start does not 
call the storage function activate_volume neither prior nor after the 
call to the function path. This leads to the following questions:
1) Should a call to path in a storage plugin always implicitly have the 
storage plugin activate the volume?
2) Should savevm-start call the storage plugins function activate_volume 
before or after calling path?

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------

----

This mail was virus scanned and spam checked before delivery.
This mail is also DKIM signed. See header dkim-signature.




More information about the pve-devel mailing list