[pve-devel] [PATCH manager 00/10] ceph changes for luminous

[Fabian Grünbichler]

LGTM, a few nit-picks below.

On Mon, Jul 31, 2017 at 11:28:32AM +0200, Dominik Csapak wrote:
> this series fixes a few things with ceph luminous
> 
> we now use crush_rule instead of crush_ruleset correctly

pre-select the first (and in most cases, only) rule on the GUI for this.

> we are able to set a different device for bluestore db/wal

please check for and catch the invalid combination filestore + wal
instead of silently dropping the wal parameter.

> we correctly delete all partitions of osds when destroying
> we improve the gui (bluestore checkbox, nicer icons, correct reload)

the top-level icon in the OSD view could be replaced by the
cluster/datacenter one.

> 
> Dominik Csapak (10):
>   enable using a device for bluestore block db/wal
>   correctly remove partitions for ceph bluestore osds
>   add osd device class to osd tree
>   make crush rules working again
>   fix #1465: use a combobox for the crush rule instead of the id
>   also get the crush rule name in the ceph pool list
>   reload the pool grid correctly
>   use better icons in the ceph osd tree view
>   add a bluestore checkbox to the create osd window
>   indentation and jslint fix
> 
>  PVE/API2/Ceph.pm            | 141 ++++++++++++++++++++++++++++++++++----------
>  www/manager6/ceph/OSD.js    |  69 +++++++++++++++-------
>  www/manager6/ceph/Pool.js   |  83 +++++++++++++++++++++-----
>  www/manager6/window/Edit.js |   4 +-
>  4 files changed, 229 insertions(+), 68 deletions(-)
> 
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel