[pve-devel] [PATCH storage] Automatically create/delete CEPH keyring when adding/deleting RBD Storage

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Thu Jan 12 08:41:50 CET 2017


On Wed, Jan 11, 2017 at 04:28:58PM +0100, Dietmar Maurer wrote:
> > When adding an RBD storage to Proxmox this patch checks if the
> > /etc/pve/priv/ceph dir exists, if not it will create it.
> > The the client.admin keyring will be copied to it with the
> > correct name of the storage (storeid.keyring)
> 
> The /etc/pve/priv/ceph.client.admin.keyring is correct for a
> local ceph installation, but always wrong for external servers.
> Or do I miss something?

maybe we could go the opposite way, and add a new API path to pveceph?
something like the following, with NAME defaulting to 'rbd':

pveceph addstorage <storagename> [-poolname NAME] [-storageoptionN VALUE]

alternatively just having [-krbd] as storage option might be enough? the
rest can be edited after the fact and are not Ceph specific (and shared
1, images/rootfs only depending on krbd and not limited to any specific
nodes seem like reasonable defaults to me).

this could read the monitors from the existing ceph configuration, copy
the local keyring to /etc/pve/priv/ceph using the correct file name and
finally add the storage with the proper options. this could then be the
last step in the installation guide instead of manual configuration.

also we could add a button to the ceph pool view part of the GUI that
calls this API path and adds the selected pool as storage, taking care
of the keyring setup along the way..

@dominik, dietmar: does this sound reasonable?



More information about the pve-devel mailing list