[pve-devel] [PATCH 0/9] get rid of PVE::REST

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Tue Jan 10 15:58:55 CET 2017


On Tue, Jan 10, 2017 at 11:55:17AM +0100, Dietmar Maurer wrote:
> I want to split out HTTPServer into a separate package. This is much
> easiere if we remove the PVE::REST class, which does not really add
> any value.
> 

see feedback on individual patches - only minor nitpicks (which could
also be fixed in follow-up patches)

patch #8 seems to be unrelated?

> 
> Dietmar Maurer (9):
>   HTTPServer.pm: add cookie handling methods
>   HTTPServer.pm: add auth_handler
>   HTTPServer.pm: allow to set baseuri when creating the class
>   HTTPServer.pm: add rest_handler method
>   HTTPServer.pm: add missing 'use' statements
>   PVE/Service/pveproxy.pm: avoid using PVE::REST
>   PVE/API2/Formatter/HTML.pm: avoid use of PVE::REST
>   bin/Makefile: export PERLLIB=.. so that doc generator works correctly
>   remove obsolete PVE::REST class
> 
>  PVE/API2/Formatter/HTML.pm |   5 +-
>  PVE/HTTPServer.pm          | 214 ++++++++++++++++++++++++++++++++++++++++++---
>  PVE/Makefile               |   1 -
>  PVE/REST.pm                | 203 ------------------------------------------
>  PVE/Service/pveproxy.pm    |   2 +-
>  bin/Makefile               |   2 +
>  6 files changed, 206 insertions(+), 221 deletions(-)
>  delete mode 100644 PVE/REST.pm
> 
> -- 
> 2.1.4
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list