[pve-devel] [PATCH qemu-server 3/4] drive-mirror: bump timeout to 5s, add 30s inactivity timeout

Alexandre DERUMIER aderumier at odiso.com
Thu Jan 5 11:05:26 CET 2017


The drive-mirror qmp command have a timeout of 3s by default (QMPCLient.pm),

shouldn't we bump it to 6s ?  (more than 5s connect-timeout ?)

----- Mail original -----
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 5 Janvier 2017 10:09:28
Objet: [pve-devel] [PATCH qemu-server 3/4] drive-mirror: bump timeout to	5s, add 30s inactivity timeout

--- 
PVE/QemuServer.pm | 2 +- 
1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm 
index 31e30fa..c2fa20b 100644 
--- a/PVE/QemuServer.pm 
+++ b/PVE/QemuServer.pm 
@@ -5919,7 +5919,7 @@ sub qemu_drive_mirror { 
$format = "nbd"; 
my $unixsocket = "/run/qemu-server/$vmid.mirror-drive-$drive"; 
$qemu_target = "nbd+unix:///$exportname?socket=$unixsocket"; 
- my $cmd = ['socat', "UNIX-LISTEN:$unixsocket,fork", "TCP:$server:$2,connect-timeout=1"]; 
+ my $cmd = ['socat', '-T30', "UNIX-LISTEN:$unixsocket,fork", "TCP:$server:$2,connect-timeout=5"]; 

my $pid = fork(); 
if (!defined($pid)) { 
-- 
2.1.4 


_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 



More information about the pve-devel mailing list