[pve-devel] applied: [PATCH v2 qemu-server] fix bad scsihw default value check

[Wolfgang Bumiller]

applied

On Mon, Feb 13, 2017 at 02:10:32PM +0100, Wolfgang Bumiller wrote:
> This was checking for scsihw being set in both branches
> whereas lsi is also the default. Added the missing 'not'.
> 
> Fixes a bug where a VM with a disk with a scsi index >= 7
> refused to start due to an invalid scsi id.
> 
> Reported-by: Friedrich Ramberger <f.ramberger at proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index a9707c8..e084981 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -6304,7 +6304,7 @@ sub scsihw_infos {
>  
>      my $maxdev = 0;
>  
> -    if ($conf->{scsihw} && ($conf->{scsihw} =~ m/^lsi/)) {
> +    if (!$conf->{scsihw} || ($conf->{scsihw} =~ m/^lsi/)) {
>          $maxdev = 7;
>      } elsif ($conf->{scsihw} && ($conf->{scsihw} eq 'virtio-scsi-single')) {
>          $maxdev = 1;
> -- 
> 2.1.4