[pve-devel] [PATCH manager] pveperf: remove outated POD replaced by pve-docs

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Feb 10 20:53:55 CET 2017


Remove the POD content and the overwriting makefile rule
'pveperf.1.pod' so that the rule from pve-doc-generator.mk matches

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

The following binaries have POD contents which isn't already in pve-docs:
* pveupgrade
* pvereport
* pveversion
* pvesh

Should those get converted to .adoc and moved to pve-docs (maybe even extended
a bit during this process), or was there a reason to keep them here?

 bin/Makefile |  4 ----
 bin/pveperf  | 34 ----------------------------------
 2 files changed, 38 deletions(-)

diff --git a/bin/Makefile b/bin/Makefile
index ae991fe..f9143ea 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -49,10 +49,6 @@ pveupgrade.1.pod: pveupgrade
 	podselect $< > $@.tmp
 	mv $@.tmp $@
 
-pveperf.1.pod: pveperf
-	podselect $< > $@.tmp
-	mv $@.tmp $@
-
 pvesh.1.pod: pvesh
 	podselect $< > $@.tmp
 	mv $@.tmp $@
diff --git a/bin/pveperf b/bin/pveperf
index 55e97b4..6f6fe2d 100755
--- a/bin/pveperf
+++ b/bin/pveperf
@@ -266,37 +266,3 @@ test_fsync ($path) if $hdo_avail;
 test_dns ();
 
 exit (0);
-
-__END__
-
-=head1 NAME
-                                          
-pveperf - the Proxmox benchmark
-
-=head1 SYNOPSIS
-
-pveperf [PATH]
-
-=head1 DESCRIPTION
-
-Tries to gather some CPU/Hardisk performance data on the hardisk
-mounted at PATH (/ is used as default) 
-
-* CPU BOGOMIPS: bogomips sum of all CPUs
-
-* REGEX/SECOND: regular expressions per second (perl performance test), should be above 300000
-
-* HD SIZE: harddisk size
-
-* BUFFERED READS: simple HD read test. Modern HDs should reach 
-at least 40 MB/sec
-
-* AVERAGE SEEK TIME: tests average seek time. Fast SCSI HDs reach values < 8 milliseconds. Common IDE/SATA disks get values from 15 to 20 ms.
-
-* FSYNCS/SECOND: value should be greater than 200 (you should 
-enable 'write back' cache mode on you RAID controller - needs a battery 
-backed cache (BBWC)).
-
-* DNS EXT: average time to resolve an external DNS name
-
-* DNS INT: average time to resolve a local DNS name
-- 
2.1.4





More information about the pve-devel mailing list