[pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

Emmanuel Kasper e.kasper at proxmox.com
Thu Feb 9 16:13:39 CET 2017


+	    emptyText: gettext('Same as source'),

On 02/08/2017 07:05 PM, Dietmar Maurer wrote:
> I would like to avoid additional gettext entries if possible.
> 
> Do we know the source storage? If so, can we set that storage as 'emptyText'?
> Other ideas?

We don't know the source storage*s*, we have only the limited info from
the Resource Store at that point. (vmid, vm name, isTemplate ... )

We could do here an API call to get the list of storages from the source
VM but I am not sure if a concatenated list of storages in the box will
be much readable.

As an alternative I was thinking of rewriting the emptyText as

Ext.String.format(gettext('Same as {0}'), vmid),

in the hope of making the new gettext string reusable.







More information about the pve-devel mailing list