[pve-devel] [PATCH manager] Use ip from iproute2 package instead of net-tools

[Emmanuel Kasper]

On 02/06/2017 03:02 PM, Wolfgang Bumiller wrote:
> On Mon, Feb 06, 2017 at 02:37:16PM +0100, Emmanuel Kasper wrote:
>> iproute2 is a direct depency from pve-qemu-kvm and should
>> be always available
>>
>> use -statistics so we get the RX/TX traffic sum like ifconfig
>> ---
>>  PVE/Report.pm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/PVE/Report.pm b/PVE/Report.pm
>> index 901fcf8..d32b968 100644
>> --- a/PVE/Report.pm
>> +++ b/PVE/Report.pm
>> @@ -27,7 +27,7 @@ if (system('command -v multipath > /dev/null 2>&1') == 0) {
>>  
>>  my @machines = ('qm list', sub { dir2text('/etc/pve/qemu-server/', '\d.*conf') });
>>  
>> -my @net = ('ifconfig', 'cat /etc/network/interfaces', sub { dir2text('/etc/pve/firewall/', '.*fw') },
>> +my @net = ('ip -statistics address', 'cat /etc/network/interfaces', sub { dir2text('/etc/pve/firewall/', '.*fw') },
> 
> Any reason not to include -details?
> It would include the vlan protocol, tun vs tap distinction etc.

Up to now I never needed this information since I infer from the name of
the device if it's a tap or vlan device, but I have nothing against
having more details.
(will v2 the patch)