[pve-devel] [PATCH cluster v3 00/14] Allow adding/deleting nodes and cluster creation over API

[Fabian Grünbichler]

On Tue, Dec 19, 2017 at 12:52:25PM +0100, Thomas Lamprecht wrote:
> Third iteration of this series, see [1] for the cover letter of the last on.
> 
> This series depends on the apiclient exception series and the common v2
> run_command: add 'quiet' parameter series.

high level feedback:

- maybe extend join_info to return info for whole cluster (makes more
  sense from an API design viewpoint IMHO - a client can then present it
  to the user or select one automatically, even if we don't use this
  functionality ourselves)
- create/join and 'pvecm add' should probably all get some kind of local
  flock to ensure crazy admins don't run them in parallel - not sure
  about interaction with addnode/delnode at various stages?
- addnode / delnode could maybe be moved to get the node name as path
  parameter, i.e. POST/DELETE cluster/config/nodes/FOO
- fingerprint should be moved to its own format for future re-use
- some of the descriptions of parameters might benefit from being
  reworded (but this might also be a candidate for follow-up work)

like discussed, the POST to cluster/config/join is not very RESTy, but I
don't see an easy way out. if someone else has a good solution, please
shout ;) one proposal was to merge create and join (since both are in a
way modifications of the cluster config), but that would not improve
readability and make the API confusing, while leaving the GET for the
join info as its own API path..

all in all, this seems to work pretty well already!