[pve-devel] [PATCH widget-toolkit 2/4] check earlier if the logview is destroyed

Dominik Csapak d.csapak at proxmox.com
Mon Dec 18 10:56:43 CET 2017


this is a port from pve-manager commit:
bde1efbf66cf8794d99708b41d92b2106c44f192

which fixes a problem with destroying the logview in extjs 6.2

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 panel/LogView.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/panel/LogView.js b/panel/LogView.js
index 73b71c4..05a90a3 100644
--- a/panel/LogView.js
+++ b/panel/LogView.js
@@ -39,12 +39,13 @@ Ext.define('Proxmox.panel.LogView', {
 
     updateView: function(start, end, total, text) {
         var me = this;
-	var el = me.dataCmp.el;
 
 	if (me.destroyed) { // return if element is not there anymore
 	    return;
 	}
 
+	var el = me.dataCmp.el;
+
 	if (me.viewInfo && me.viewInfo.start === start &&
 	    me.viewInfo.end === end && me.viewInfo.total === total &&
 	    me.viewInfo.textLength === text.length) {
-- 
2.11.0





More information about the pve-devel mailing list