[pve-devel] [RFC manager 00/28] Integrate widget toolkit into PVE webUI

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 11 16:25:49 CET 2017


This is my split of the widget toolkit (re)integration.

I looked at the following shared modules, compared the changes made
since the fork and switched the usage to them.

./form/LanguageSelector.js
./form/BondModeSelector.js
./form/Checkbox.js
./form/RRDTypeSelector.js
./form/KVComboBox.js
./grid/ObjectGrid.js
./grid/PendingObjectGrid.js
./window/Edit.js
./window/TaskViewer.js
./window/PasswordEdit.js
./button/HelpButton.js
./data/DiffStore.js
./data/TimezoneStore.js
./data/reader/JsonObject.js
./data/ObjectStore.js
./data/ProxmoxProxy.js
./panel/GaugeWidget.js
./panel/LogView.js
./panel/InputPanel.js


Dominiks initial patch to allow the use of the toolkit is included
here, to ease testing.
Especially the addition of ObjectGrud resulted in some bigger cleanups
in users of that module.

This series depends on the not yet applied 'HelpButton: be backward
compatible with PVE help mapping' widget toolkit patch of mine on top
of a latest commit build.

Quite some modules had none to minor changes at all, I tried to test
after each module switch - but as there are so many components not all
could be sanely tested.

cheers,
Thomas

Dominik Csapak (1):
  add proxmox-widget-toolkit to pve gui

Thomas Lamprecht (27):
  use LanguageSelector from widget toolkit
  use BondModeSelector & BondPolicySelector from widget toolkit
  use Checkbox from widget toolkit
  use RRDTypeSelector from widget toolkit
  use KVCombobox from widget toolkit
  use ObjectGrid from widget toolkit
  dc/OptionView: cleanup & use new features from ObjectGrid
  lxc/Resources: cleanup & use new features from ObjectGrid
  lxc/Options: cleanup & use a few new features from ObjectGrid
  grid/FireWallOptions: cleanup & use new features from ObjectGrid
  qemu/Options: cleanup & use new features from ObjectGrid
  use PendingObjectGrid from widget toolkit
  use windowEdit from widget toolkit
  use TaskViewer & TaskProgress window from widget toolkit
  use window.PasswordEdit from widget toolkit
  use HelpButton from widget toolkit
  use DiffStore from widget toolkit
  use TimezoneStore from widget toolkit
  TimeEdit: use schematic declaration
  use JsonObject reader from widget toolkit
  use ObjectStore from widget toolkit
  use RestProxy from widget toolkit
  use GaugeWidget from widget toolkit
  use LogView from widget toolkit
  use InputPanel from widget toolkit
  RealmComboBox: use schematic declaration and ViewController
  buildsys: we need pve-doc-generator to build package

 PVE/Service/pveproxy.pm                        |   3 +
 debian/control                                 |   2 +
 www/css/ext6-pve.css                           |   2 +-
 www/index.html.tpl                             |   8 +
 www/manager6/Makefile                          |  19 +-
 www/manager6/Toolkit.js                        |   6 +
 www/manager6/Utils.js                          |  42 +--
 www/manager6/Workspace.js                      |   2 +-
 www/manager6/button/HelpButton.js              |  78 -----
 www/manager6/ceph/Monitor.js                   |  10 +-
 www/manager6/ceph/OSD.js                       |  12 +-
 www/manager6/ceph/Pool.js                      |  10 +-
 www/manager6/ceph/Status.js                    |   4 +-
 www/manager6/data/DiffStore.js                 | 114 -------
 www/manager6/data/Models.js                    |  31 ++
 www/manager6/data/ObjectStore.js               |  35 ---
 www/manager6/data/PVEProxy.js                  | 102 ------
 www/manager6/data/RRDStore.js                  |   4 +-
 www/manager6/data/ResourceStore.js             |   2 +-
 www/manager6/data/TimezoneStore.js             | 418 -------------------------
 www/manager6/data/reader/JsonObject.js         | 127 --------
 www/manager6/dc/ACLView.js                     |   8 +-
 www/manager6/dc/AuthEdit.js                    |  10 +-
 www/manager6/dc/Backup.js                      |  12 +-
 www/manager6/dc/GroupEdit.js                   |   2 +-
 www/manager6/dc/Health.js                      |   2 +-
 www/manager6/dc/Log.js                         |   8 +-
 www/manager6/dc/OptionView.js                  | 257 +++------------
 www/manager6/dc/PoolEdit.js                    |   2 +-
 www/manager6/dc/SecurityGroups.js              |   6 +-
 www/manager6/dc/StorageView.js                 |   2 +-
 www/manager6/dc/Summary.js                     |   6 +-
 www/manager6/dc/Tasks.js                       |   8 +-
 www/manager6/dc/UserEdit.js                    |   6 +-
 www/manager6/dc/UserView.js                    |  55 +---
 www/manager6/form/BackupModeSelector.js        |   2 +-
 www/manager6/form/BondModeSelector.js          |  42 ---
 www/manager6/form/Boolean.js                   |   2 +-
 www/manager6/form/BridgeSelector.js            |   2 +-
 www/manager6/form/BusTypeSelector.js           |   2 +-
 www/manager6/form/CPUModelSelector.js          |   2 +-
 www/manager6/form/CacheTypeSelector.js         |   2 +-
 www/manager6/form/CephPoolSelector.js          |   2 +-
 www/manager6/form/Checkbox.js                  |  44 ---
 www/manager6/form/CompressionSelector.js       |   2 +-
 www/manager6/form/ContentTypeSelector.js       |   2 +-
 www/manager6/form/DayOfWeekSelector.js         |   2 +-
 www/manager6/form/DiskFormatSelector.js        |   2 +-
 www/manager6/form/DisplaySelector.js           |   2 +-
 www/manager6/form/EmailNotificationSelector.js |   2 +-
 www/manager6/form/FileSelector.js              |   2 +-
 www/manager6/form/FirewallPolicySelector.js    |   2 +-
 www/manager6/form/GlobalSearchField.js         |   2 +-
 www/manager6/form/GroupSelector.js             |   2 +-
 www/manager6/form/IPRefSelector.js             |   2 +-
 www/manager6/form/KVComboBox.js                |  72 -----
 www/manager6/form/LanguageSelector.js          |   5 -
 www/manager6/form/NetworkCardSelector.js       |   2 +-
 www/manager6/form/NodeSelector.js              |   2 +-
 www/manager6/form/PoolSelector.js              |   2 +-
 www/manager6/form/QemuBiosSelector.js          |   2 +-
 www/manager6/form/RRDTypeSelector.js           |  49 ---
 www/manager6/form/RealmComboBox.js             |  53 ++--
 www/manager6/form/RoleSelector.js              |   2 +-
 www/manager6/form/ScsiHwSelector.js            |   2 +-
 www/manager6/form/SecurityGroupSelector.js     |   2 +-
 www/manager6/form/SnapshotSelector.js          |   2 +-
 www/manager6/form/StorageSelector.js           |   2 +-
 www/manager6/form/USBSelector.js               |   2 +-
 www/manager6/form/UserSelector.js              |   2 +-
 www/manager6/form/VNCKeyboardSelector.js       |   2 +-
 www/manager6/form/iScsiProviderSelector.js     |   2 +-
 www/manager6/grid/BackupView.js                |   2 +-
 www/manager6/grid/FirewallAliases.js           |   6 +-
 www/manager6/grid/FirewallOptions.js           | 135 ++------
 www/manager6/grid/FirewallRules.js             |  20 +-
 www/manager6/grid/ObjectGrid.js                | 132 --------
 www/manager6/grid/PendingObjectGrid.js         |  95 ------
 www/manager6/grid/PoolMembers.js               |   6 +-
 www/manager6/grid/Replication.js               |  10 +-
 www/manager6/ha/GroupEdit.js                   |   8 +-
 www/manager6/ha/GroupSelector.js               |   2 +-
 www/manager6/ha/ResourceEdit.js                |   6 +-
 www/manager6/ha/Resources.js                   |   2 +-
 www/manager6/ha/Status.js                      |   4 +-
 www/manager6/ha/StatusView.js                  |   2 +-
 www/manager6/lxc/Config.js                     |   4 +-
 www/manager6/lxc/CreateWizard.js               |   4 +-
 www/manager6/lxc/DNS.js                        |   8 +-
 www/manager6/lxc/MPEdit.js                     |  20 +-
 www/manager6/lxc/MPResize.js                   |   2 +-
 www/manager6/lxc/Network.js                    |   6 +-
 www/manager6/lxc/Options.js                    |  72 ++---
 www/manager6/lxc/ResourceEdit.js               |   8 +-
 www/manager6/lxc/Resources.js                  |  89 ++----
 www/manager6/lxc/Snapshot.js                   |   2 +-
 www/manager6/lxc/SnapshotTree.js               |   4 +-
 www/manager6/lxc/Summary.js                    |   2 +-
 www/manager6/node/APT.js                       |   4 +-
 www/manager6/node/Config.js                    |   8 +-
 www/manager6/node/DNSEdit.js                   |   2 +-
 www/manager6/node/DNSView.js                   |   2 +-
 www/manager6/node/Disks.js                     |   6 +-
 www/manager6/node/NetworkEdit.js               |   6 +-
 www/manager6/node/NetworkView.js               |   2 +-
 www/manager6/node/ServiceView.js               |   6 +-
 www/manager6/node/Subscription.js              |   4 +-
 www/manager6/node/Summary.js                   |   2 +-
 www/manager6/node/Tasks.js                     |   6 +-
 www/manager6/node/TimeEdit.js                  |  49 ++-
 www/manager6/node/TimeView.js                  |   2 +-
 www/manager6/panel/ConfigPanel.js              |   2 +-
 www/manager6/panel/GaugeWidget.js              |  96 ------
 www/manager6/panel/IPSet.js                    |  14 +-
 www/manager6/panel/InputPanel.js               | 124 --------
 www/manager6/panel/LogView.js                  | 274 ----------------
 www/manager6/panel/RRDView.js                  |   2 +-
 www/manager6/pool/StatusView.js                |   2 +-
 www/manager6/qemu/BootOrderEdit.js             |  10 +-
 www/manager6/qemu/CDEdit.js                    |   4 +-
 www/manager6/qemu/CPUOptions.js                |   4 +-
 www/manager6/qemu/Clone.js                     |   4 +-
 www/manager6/qemu/Config.js                    |   4 +-
 www/manager6/qemu/DisplayEdit.js               |   2 +-
 www/manager6/qemu/HDEdit.js                    |  14 +-
 www/manager6/qemu/HDEfi.js                     |   4 +-
 www/manager6/qemu/HDMove.js                    |   4 +-
 www/manager6/qemu/HDThrottle.js                |   4 +-
 www/manager6/qemu/HardwareView.js              |   2 +-
 www/manager6/qemu/KeyboardEdit.js              |   2 +-
 www/manager6/qemu/MemoryEdit.js                |   6 +-
 www/manager6/qemu/NetworkEdit.js               |   8 +-
 www/manager6/qemu/OSTypeEdit.js                |   4 +-
 www/manager6/qemu/Options.js                   |  91 ++----
 www/manager6/qemu/ProcessorEdit.js             |   6 +-
 www/manager6/qemu/QemuBiosEdit.js              |   2 +-
 www/manager6/qemu/ScsiHwEdit.js                |   2 +-
 www/manager6/qemu/Smbios1Edit.js               |   4 +-
 www/manager6/qemu/Snapshot.js                  |   4 +-
 www/manager6/qemu/SnapshotTree.js              |   4 +-
 www/manager6/qemu/Summary.js                   |   2 +-
 www/manager6/qemu/USBEdit.js                   |   4 +-
 www/manager6/storage/ContentView.js            |   8 +-
 www/manager6/storage/DirEdit.js                |   8 +-
 www/manager6/storage/GlusterFsEdit.js          |   8 +-
 www/manager6/storage/IScsiEdit.js              |   8 +-
 www/manager6/storage/LVMEdit.js                |  12 +-
 www/manager6/storage/LvmThinEdit.js            |  10 +-
 www/manager6/storage/NFSEdit.js                |   8 +-
 www/manager6/storage/RBDEdit.js                |   8 +-
 www/manager6/storage/SheepdogEdit.js           |   6 +-
 www/manager6/storage/Summary.js                |   4 +-
 www/manager6/storage/ZFSEdit.js                |  10 +-
 www/manager6/storage/ZFSPoolEdit.js            |  10 +-
 www/manager6/window/Backup.js                  |   4 +-
 www/manager6/window/BulkAction.js              |   2 +-
 www/manager6/window/Edit.js                    | 308 ------------------
 www/manager6/window/LoginWindow.js             |   2 +-
 www/manager6/window/Migrate.js                 |   8 +-
 www/manager6/window/MigrateAll.js              |   2 +-
 www/manager6/window/NotesEdit.js               |   2 +-
 www/manager6/window/Restore.js                 |   6 +-
 www/manager6/window/SafeDestroy.js             |   2 +-
 www/manager6/window/Settings.js                |   4 +-
 www/manager6/window/StartupEdit.js             |   4 +-
 www/manager6/window/TaskViewer.js              | 223 -------------
 www/manager6/window/Wizard.js                  |   2 +-
 167 files changed, 559 insertions(+), 3311 deletions(-)
 delete mode 100644 www/manager6/button/HelpButton.js
 delete mode 100644 www/manager6/data/DiffStore.js
 create mode 100644 www/manager6/data/Models.js
 delete mode 100644 www/manager6/data/ObjectStore.js
 delete mode 100644 www/manager6/data/PVEProxy.js
 delete mode 100644 www/manager6/data/TimezoneStore.js
 delete mode 100644 www/manager6/data/reader/JsonObject.js
 delete mode 100644 www/manager6/form/BondModeSelector.js
 delete mode 100644 www/manager6/form/Checkbox.js
 delete mode 100644 www/manager6/form/KVComboBox.js
 delete mode 100644 www/manager6/form/LanguageSelector.js
 delete mode 100644 www/manager6/form/RRDTypeSelector.js
 delete mode 100644 www/manager6/grid/ObjectGrid.js
 delete mode 100644 www/manager6/grid/PendingObjectGrid.js
 delete mode 100644 www/manager6/panel/GaugeWidget.js
 delete mode 100644 www/manager6/panel/InputPanel.js
 delete mode 100644 www/manager6/panel/LogView.js
 delete mode 100644 www/manager6/window/Edit.js
 delete mode 100644 www/manager6/window/TaskViewer.js

-- 
2.11.0





More information about the pve-devel mailing list