[pve-devel] applied: [PATCH common 1/2] wait_for_vnc_port: die if port did not get ready

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Dec 5 13:53:06 CET 2017


applied both patches

On Mon, Dec 04, 2017 at 11:30:10AM +0100, Thomas Lamprecht wrote:
> All of our users expected this behavior and did not check for undef
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  src/PVE/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index c3ac0e8..c2c2f93 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -812,7 +812,7 @@ sub wait_for_vnc_port {
>  	usleep($sleeptime);
>      }
>  
> -    return undef;
> +    die "Timeout while waiting for port '$port' to get ready!\n";
>  }
>  
>  sub next_unused_port {
> -- 
> 2.11.0




More information about the pve-devel mailing list