[pve-devel] [PATCH qemu-server] fix #1570: fix template backup with pigz

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 4 08:38:09 CET 2017


On 12/01/2017 11:43 AM, Dominik Csapak wrote:
> when using pigz the resulting commandline would look like:
> 
> pigz -p 4>file
> 
> which resulted in pigz erroring out because it got no parameter for -p
> (because the shell interpreted the 4>file as a file descriptor)
> 
> this patch adds a space so that the resulting line is
> pigz -p 4 > file
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/VZDump/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
> index a630829..42680f8 100644
> --- a/PVE/VZDump/QemuServer.pm
> +++ b/PVE/VZDump/QemuServer.pm
> @@ -274,7 +274,7 @@ sub archive {
>  	    $outcmd = "exec:cat";
>  	}
>  
> -	$outcmd .= ">$filename" if !$opts->{stdout};
> +	$outcmd .= " > $filename" if !$opts->{stdout};
>  
>  	my $cmd = ['/usr/bin/vma', 'create', '-v', '-c', $conffile];
>  	push @$cmd, '-c', $firewall if -e $firewall;
> 

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>




More information about the pve-devel mailing list