[pve-devel] [PATCH cluster] pvecm create: there is no rrp_mode param anymore

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Dec 1 11:09:01 CET 2017


We removed the possibility to pass a rrp_mode param to the create call
in commit 606a890448f0a6219db3d1c19b98960a3dcbcaa8 so this check is
rather useless.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

Discovered during my cluster api work, send already as it's
independent and would only be noise in the series

 data/PVE/CLI/pvecm.pm | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm
index e3c3661..07ae0af 100755
--- a/data/PVE/CLI/pvecm.pm
+++ b/data/PVE/CLI/pvecm.pm
@@ -169,14 +169,6 @@ __PACKAGE__->register_method ({
 	    $interfaces .= "rrp_mode: passive\n"; # only passive is stable and tested
 
 	    $ring_addresses .= "\n    ring1_addr: $param->{ring1_addr}";
-
-	} elsif($param->{rrp_mode} && $param->{rrp_mode} ne 'none') {
-
-	    warn "rrp_mode '$param->{rrp_mode}' useless when using only one".
-		" ring, using 'none' instead";
-	    # corosync defaults to none if only one interface is configured
-	    $param->{rrp_mode} = undef;
-
 	}
 
 	# No, corosync cannot deduce this on its own
-- 
2.11.0





More information about the pve-devel mailing list