[pve-devel] [PATCH manager v2 3/3] ui: ObjectPendingGrid: use	darkorange and append '(pending)'
    Thomas Lamprecht 
    t.lamprecht at proxmox.com
       
    Thu Aug 31 14:26:01 CEST 2017
    
    
  
red is normally strongly associated with errors, put pending changes
are not errors.
Thus, use darkorange, to not scare (new) users and annotate the
pending entry with '(pending)' to make it easier to see what, or
better why coloring happens.
---
changes v1 -> v2:
 * use darkorange instead of proxmox orange hex value
 * split up in three lines to gain readability
 www/manager6/grid/PendingObjectGrid.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/PendingObjectGrid.js b/www/manager6/grid/PendingObjectGrid.js
index 43889456..253e2b22 100644
--- a/www/manager6/grid/PendingObjectGrid.js
+++ b/www/manager6/grid/PendingObjectGrid.js
@@ -64,7 +64,9 @@ Ext.define('PVE.grid.PendingObjectGrid', {
 	}
 
 	if (pending || pendingdelete) {
-	    current += '<div style="color:red">' + pending + pendingdelete + '</div>';
+	    current += '<div style="color:darkorange">';
+	    current += pending + pendingdelete + ' (' + gettext('pending') + ')';
+	    current += '</div>';
 	}
 	return current;
     },
-- 
2.11.0
    
    
More information about the pve-devel
mailing list