[pve-devel] [PATCH manager/storage v3 00/20] pveceph storage.cfg maangement

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Aug 31 11:38:03 CEST 2017


this patch series implements storage.cfg management for pveceph-managed ceph
clusters.

the following is implemented:

- add new 'pveceph' flag to RBD storages, using /etc/pve/ceph.conf instead of
  a hard-coded monitor list
- optionally adding/removing storages when creating/destroying a pool + GUI
- creating/destroying pools happens in a worker now
- adding/removing a pveceph-managed RBD storage handles its keyring as well

the following is still missing:
- make switching to (and from?) pveceph possible via API for an existing storage
- adapt RBD add/edit dialogue in GUI (follow up by Thomas?)

high-level changes since v2 based on Thomas' feedback:
- moved keyring handling to pve-storage (PVE::API2::Storage::Config)
- dropped add/list/removestorages API paths in PVE::API2::Ceph

high-level changes since v1:
- pveceph flag is now doing its magic on the storage plugin side as well, no
  more need to update the monhost string when adding/removing a monitor (thanks
  for the suggestion Dietmar!)
- createpool/destroypool are now using a worker
- treat more failures as fatal in API paths
- {name} API placeholder for pool names is now {pool}
- includes and extends Dominik's GUI patches to support the new functionality

mapping of v2 to v3 patches:
1,2 -> 1
3 -> 3
4 -> 4
6 -> 6
7 -> 7
15,17 -> 8
16 -> 9
18 -> 10
20 -> 12
21 -> 14
22 -> 15
23 -> 16
24 -> 17
26 -> 18
27 -> 19

new in v3:
2, 5, 11, 13, 20

dropped since v2:
5, 8-14, 19, 25



pve-storage:

Fabian Grünbichler (5):
  rbd: add pveceph storage option
  rbd: implement check_config
  rbd: refactor cmdline helpers
  rbd: implement pveceph flag handling
  rbd: manage keyring for pveceph storages

 PVE/API2/Storage/Config.pm | 24 +++++++++++--
 PVE/Storage/RBDPlugin.pm   | 90 ++++++++++++++++++++++++++--------------------
 2 files changed, 74 insertions(+), 40 deletions(-)


base-commit: 5a2eba91dcaec0ba68052579d5e0e4ebcb499ff5


pve-manager:

Dominik Csapak (3):
  add a params object to the safedestroy window
  add add storages checkbox to ceph pool creation
  add remove_storages parameter to the pool destruction

Fabian Grünbichler (12):
  ceph: add add_storage helper
  ceph: add get_storages helper
  ceph: create/destroypool: shorten variable name
  ceph/createpool: optionally add storages
  ceph/destroypool: optionally remove storages
  ceph/destroypool: refactor to use get_storages
  ceph: make create/destroypool API paths async
  ceph/destroypool: move image check into worker
  add task description for cephcreatepool
  add showProgress to SafeDestroy
  enable showProgress for create/destroy pool
  rename 'Remove' ceph pool button to 'Destroy'

 PVE/API2/Ceph.pm                   | 215 ++++++++++++++++++++++++++-----------
 www/manager6/Utils.js              |   1 +
 www/manager6/ceph/Pool.js          |  17 ++-
 www/manager6/window/SafeDestroy.js |  39 ++++++-
 4 files changed, 205 insertions(+), 67 deletions(-)


base-commit: f9346961588e086a9cc86d00c16f7f3d0a77c878
-- 
2.11.0




More information about the pve-devel mailing list