[pve-devel] [PATCH v2 storage/manager 00/27] pveceph storage.cfg maangement

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 29 16:45:38 CEST 2017


On 08/29/2017 01:04 PM, Fabian Grünbichler wrote:
> this patch series implements storage.cfg management for pveceph-managed ceph
> clusters. the following is implemented:
> 
> - add new 'pveceph' flag to RBD storages, using /etc/pve/ceph.conf instead of
>    a hard-coded monitor list
> - pveceph addstorage/lsstorages/removestorage to add/list/remove storage
>    entries, per pool
> - optionally adding/removing storages when creating/destroying a pool
> - GUI support
> 
> high-level changes since v1:
> - pveceph flag is now doing its magic on the storage plugin side as well, no
>    more need to update the monhost string when adding/removing a monitor (thanks
>    for the suggestion Dietmar!)
> - createpool/destroypool are now using a worker
> - treat more failures as fatal in API paths
> - {name} API placeholder for pool names is now {pool}
> - includes and extends Dominik's GUI patches to support the new functionality
> 
> patches 2-4, 17, 19-21, 26 and 27 are new
> patches 22-25 are from Dominik's 'ceph pool storage creation in gui' series
> the old patches 2, 3, 5, 8 and 20 were dropped altogether
> 
> 

tried to give it a look and tested a bit around. found nothing to grave, besides
a few possible improvements/nitpicks here and there and one design issue with removal
which irks me a bit.
Every patch were I didn't reply can be seen as OK for me - didn't wanted to bother
the list by replying on each of them.

> 
> pve-storage:
> 
> Fabian Grünbichler (4):
>    rbd: add pveceph storage option
>    rbd: make monhost option optional
>    refactor cmdline helpers
>    rbd: implement pveceph flag handling
> 
>   PVE/Storage/RBDPlugin.pm | 90 ++++++++++++++++++++++++++++--------------------
>   1 file changed, 53 insertions(+), 37 deletions(-)
> 
> 
> base-commit: 5a2eba91dcaec0ba68052579d5e0e4ebcb499ff5
> 
> 
> 
> pve-manager:
> 
> Dominik Csapak (4):
>    add a params object to the safedestroy window
>    add create storages checkbox to ceph pool creation
>    add remove_storages parameter to the pool destruction
>    add a 'create storage' button for ceph pools
> 
> Fabian Grünbichler (19):
>    ceph: add /etc/pve/priv/ceph path
>    ceph: add add_storage helper
>    ceph: add get_storages helper
>    ceph: add remove_storage helper
>    ceph: implement addstorage API path
>    pveceph: add addstorage CLI command
>    ceph: implement lsstorages API path
>    pveceph: add lsstorages CLI command
>    ceph: implement removestorage API path
>    pveceph: add removestorage CLI command
>    ceph/createpool: shorten pool variable name
>    ceph/createpool: optionally add storages
>    ceph/destroypool: shorten pool variable name
>    ceph/destroypool: optionally remove storages
>    ceph: rename API placeholder 'name' to 'pool'
>    ceph: make create/destroypool API paths async
>    add task description for cephcreatepool
>    add showProgress to SafeDestroy
>    enable showProgress for create/destroy pool
> 
>   PVE/API2/Ceph.pm                   | 367 +++++++++++++++++++++++++++++++------
>   PVE/CLI/pveceph.pm                 |  24 ++-
>   PVE/CephTools.pm                   |   2 +
>   www/manager6/Utils.js              |   1 +
>   www/manager6/ceph/Pool.js          |  78 +++++++-
>   www/manager6/window/SafeDestroy.js |  41 ++++-
>   6 files changed, 455 insertions(+), 58 deletions(-)
> 
> 
> base-commit: f9346961588e086a9cc86d00c16f7f3d0a77c878
> 





More information about the pve-devel mailing list