[pve-devel] [v2 manager 23/27] add create storages checkbox to ceph pool creation

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 29 15:41:06 CEST 2017


On 08/29/2017 01:04 PM, Fabian Gr├╝nbichler wrote:
> From: Dominik Csapak <d.csapak at proxmox.com>
> 
> to be able to automatically generate the ceph storages when creating a
> pool
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> identical to Dominik's v1
> 
>   www/manager6/ceph/Pool.js | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
> index ea142b47..7941324e 100644
> --- a/www/manager6/ceph/Pool.js
> +++ b/www/manager6/ceph/Pool.js
> @@ -44,6 +44,11 @@ Ext.define('PVE.CephCreatePool', {
>   	    minValue: 8,
>   	    maxValue: 32768,
>   	    allowBlank: false
> +	},
> +	{
> +	    xtype: 'pvecheckbox',
> +	    fieldLabel: gettext('Create Storages'),


I guess the user could be confused with Create Storages in the context of
pool creation, double use of 'Create' with different meanings.

Something like 'Add to Storages' would be better here, IMO.
We always use add if we speak from the storage.cfg, even the
API end point name uses 'add' not 'create'


> +	    name: 'add_storages'
>   	}
>       ],
>       initComponent : function() {
> 





More information about the pve-devel mailing list