[pve-devel] [PATCH manager 05/11] Change the SCSI controller type when editing a harddisk only when creating a VM.

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 29 12:08:28 CEST 2017


From: Emmanuel Kasper <e.kasper at proxmox.com>

If not, the following could happen:
 * user has a VM with two disks attached to a LSI controller
 * adding a third disk, he notices the iothread option, and clicks it
 * the scsihw type for all disks is changed now to virtio-scsi-single
 * on next cold restart, STOP 0x0000007B INACCESSABLE_BOOT_DEVICE for a Windows VM

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

new.
Adapted comment (indentation and wording)

 www/manager6/qemu/HDEdit.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index d1460fbb..9f06ffe7 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -104,7 +104,10 @@ Ext.define('PVE.qemu.HDInputPanel', {
 
 	if (values.iothread && confid.match(/^(virtio|scsi)\d+$/)) {
 	    me.drive.iothread = 'on';
-	    params.scsihw = 'virtio-scsi-single';
+	    // do not silently change a VM-wide option after creating it
+	    if (me.insideWizard) {
+		params.scsihw = 'virtio-scsi-single';
+	    }
 	} else {
 	    delete me.drive.iothread;
 	}
-- 
2.11.0




More information about the pve-devel mailing list