[pve-devel] [PATCH manager v2 16/17] disable discard for non-scsi disks

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Aug 23 11:34:16 CEST 2017


In general OK, but same problem as IOThread has, the checkbox should be cleared on disable.
Else, it may confuse users or give them the idea that they can outsmart the wizard
and set discard on sata (for example).

I sent a patch which addresses this with IOThread, and some other which will cause
a merge conflict. So depending on which goes in earlier this may needs to get re-spun.
I can also take this up in my queue with merge conflicts and checkbox clear issues
addressed, if you prefer.

On 07/21/2017 12:01 PM, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> added the missing 'reference' on the component
>   www/manager6/qemu/HDEdit.js | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index aeac7dd0..db3c2e9a 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -18,6 +18,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   	onControllerChange: function(field) {
>   	    var value = field.getValue();
>   	    this.lookup('iothread').setDisabled(!value.match(/^(virtio|scsi)/));
> +	    this.lookup('discard').setDisabled(!value.match(/^scsi/));
>   	},
>   
>   	control: {
> @@ -197,6 +198,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   	me.column2.push({
>   	    xtype: 'pvecheckbox',
>   	    fieldLabel: gettext('Discard'),
> +	    reference: 'discard',
>   	    name: 'discard'
>   	});
>   
> 




More information about the pve-devel mailing list